Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify the cluster property true/false #1384

Closed
IhsenBen opened this issue Jul 20, 2022 · 8 comments
Closed

modify the cluster property true/false #1384

IhsenBen opened this issue Jul 20, 2022 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers PR is more than welcomed Extra attention is needed

Comments

@IhsenBen
Copy link
Contributor

IhsenBen commented Jul 20, 2022 •
edited
Loading

Hi
seems like there's no way to modify the cluster property on the source without resetting the whole thing, is it possible to do something like this instead:

map.addSource('some id', {
type: 'geojson',
data: geodata,
cluster: true,
clusterMaxZoom: 14,
clusterRadius: 50,
});
//
//
map.getSource('some id').setCluster(false)
@HarelM
Copy link
Collaborator

HarelM commented Jul 20, 2022 •
edited
Loading

I have a feeling this was already reported, any change you can have a look?

@IhsenBen
Copy link
Contributor Author

I have a feeling this was already retorted, any change you can have a look?

Yes, I did look into the docs before posting this issue

@HarelM
Copy link
Collaborator

HarelM commented Jul 20, 2022

Somewhat related: #429

@HarelM HarelM added enhancement New feature or request PR is more than welcomed Extra attention is needed good first issue Good for newcomers labels Aug 21, 2022
@IhsenBen
Copy link
Contributor Author

Hi again
Can I work on this, please?

@HarelM
Copy link
Collaborator

HarelM commented Dec 21, 2022

Sure, enjoy! 😀

@IhsenBen IhsenBen mentioned this issue Dec 26, 2022
Merged
@IhsenBen
Copy link
Contributor Author

IhsenBen commented Dec 26, 2022 •
edited
Loading

Sure, enjoy! 😀

Just made a pull request #1998, tell me if I need to modify anything

@SnailBones
Copy link
Contributor

Looks like this should be closed since #1998 has been merged.

@IhsenBen
Copy link
Contributor Author

Looks like this should be closed since #1998 has been merged.

Yes, I added the feature, maybe when it's released?

@HarelM HarelM closed this as completed Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers PR is more than welcomed Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HarelM @SnailBones @IhsenBen