Layout benchmark broken (again)

[zhangyiatmicrosoft]

Very similar to previous two issues reported:
#1293
#1254

1. npm run ci
2. npm run start-bench
3. open web browser at http://localhost:9966/bench/versions?#Layout
4. console will show

benchmarks_generated.js:33 Uncaught TypeError: this.map.setTerrain is not a function at Jt._load (benchmarks_generated.js:33:102708) at benchmarks_generated.js:33:101895

The said script is https://maplibre.org/maplibre-gl-js/benchmarks/main/benchmarks_generated.js
NOT coming from my local box.

[HarelM]

Seems like this is related to a recent change with 3D terrain and the fact that the bench is using a map stub and that it needs to run manually. See #982 for more info.
I'll see if I can create a PR that fixes this... :-(

[HarelM]

Feel free to review my PR :-)

[HarelM]

@zhangyiatmicrosoft it would be great if you could make sure this is now fixed after the following actions is completed:
https://github.com/maplibre/maplibre-gl-js/actions/runs/3199696952
Thanks!!

[zhangyiatmicrosoft]

Confirm that this is working now. Thanks again for the quick fix!

[HarelM]

No problem. Thanks for reporting this!!