Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LngLat class toArray method return type #2233

Closed
maxdacruz opened this issue Feb 27, 2023 · 3 comments
Closed

LngLat class toArray method return type #2233

maxdacruz opened this issue Feb 27, 2023 · 3 comments

Comments

@maxdacruz
Copy link
Contributor

The toArray method on the class LngLat should return an [number,number] type instead of the number[] to stay consistent with the doc and the LngLatLike type which only accepts a [number,number] type.
@HarelM
Copy link
Collaborator

HarelM commented Feb 27, 2023

Sounds right, can you open a PR to fix this?

@maxdacruz
Copy link
Contributor Author

Will do should be done by the end of the week.

@maxdacruz maxdacruz mentioned this issue Feb 27, 2023
Merged
3 tasks
@HarelM
Copy link
Collaborator

HarelM commented Feb 27, 2023

Fixed by #2234

@HarelM HarelM closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarelM @maxdacruz