Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Swift package to maplibre-gl-native-distribution with CI #662

Closed
louwers opened this issue Jan 6, 2023 · 4 comments · Fixed by #1993
Closed

Release Swift package to maplibre-gl-native-distribution with CI #662

louwers opened this issue Jan 6, 2023 · 4 comments · Fixed by #1993
Assignees
Labels

Comments

@louwers
Copy link
Collaborator

louwers commented Jan 6, 2023

@petr-pokorny-1 made manual releases to https://github.com/maplibre/maplibre-gl-native-distribution in the past.

It would be helpful if this is automated and done during an iOS release automatically.

@louwers louwers added the iOS label Jan 6, 2023
@louwers
Copy link
Collaborator Author

louwers commented Jan 8, 2023

I made a manual release now and even duplicated the release notes so they will show up on the Swift Package Index. I guess it makes most sense to fix this once a descision has been made to split by platform. Then the maplibre-gl-native-distribution repo won't be needed anymore.

@louwers louwers self-assigned this Jan 10, 2023
@louwers louwers moved this to Todo in MapLibre Native iOS Jan 10, 2023
@roblabs
Copy link
Collaborator

roblabs commented Jan 10, 2023

@louwers — thank you for making the Swift Package release.

The distribution repo has Swift Playground called MapLibre Test, and I was able to give your manual release a test using that Playground in Xcode 14.2.

See maplibre/maplibre-gl-native-distribution#8


Screenshot of Playground for the MapLibre Swift Package
image

@louwers
Copy link
Collaborator Author

louwers commented Jan 10, 2023

@roblabs Cool, did everything work the way you expected it to?

What do you think, does it perhaps make sense to include maplibre-gl-native-distribution in this repository?

@roblabs
Copy link
Collaborator

roblabs commented Jan 10, 2023

@louwers — yes, it worked as expected in the very basic Playground test. I recommend keeping the maplibre-gl-native-distribution as is until the main Native has fully gone through it's split repo state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants