Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and publish latest documentation (probably migrating from jazzy to docc) #52

Open
5 tasks
michaelkirk opened this issue Jun 2, 2024 · 1 comment

Comments

@michaelkirk
Copy link
Collaborator

Motivation

I wanted to browse the latest API docs for maplibre-navigation-ios, but couldn't find any prebuilt. It looks like there is configuration for building docs via jazzy, but I haven't found any evidence of published documentation for malibre-navigation-ios yet.

In maplibre-native, jazzy has been succeeded by docc (issue: maplibre/maplibre-native#676)

Presumably we want to do the same thing here.

Design Alternatives

We could stay with Jazzy or pick some other documentation provider, but it seems like all the same logic in #676 applies here.

We could continue not to publish pre-built docs and have developers browse documentation in the source files, but I think it's worth going through the effort of pre-building docs and publishing it for all the same reasons anyone does this anywhere.

Design

Use cases:

  • CI will build docs
  • CI will publish docs
  • Local dev should be able to build docs for their own usage
  • Local dev should be able to build docs to preview their documentation changes

Mock-Up

I'm assuming we'll use whatever documentation style is used by maplibre-native (or the default style)

Concepts

n/a

Implementation

@michaelkirk
Copy link
Collaborator Author

Currently, swift package generate-documentation fails: https://github.com/michaelkirk/maplibre-navigation-ios/actions/runs/9358227464/job/25759607313?pr=1#step:4:148

The error is:

In file included from /Users/runner/work/maplibre-navigation-ios/maplibre-navigation-ios/MapboxNavigationObjC/MLNMapView+MLNNavigationAdditions.m:1:
/Users/runner/work/maplibre-navigation-ios/maplibre-navigation-ios/MapboxNavigationObjC/MLNMapView+MLNNavigationAdditions.h:1:9: fatal error: 'MapLibre/Mapbox.h' file not found
#import <MapLibre/Mapbox.h>
        ^~~~~~~~~~~~~~~~~~~
1 error generated.
[25/93] Compiling MapboxNavigationObjC MLNMapView+MLNNavigationAdditions.m
[25/93] Compiling MapboxNavigationObjC MBRouteVoiceController.m
error: unspecified("fatalError")
Generating documentation for 'MapboxNavigation'...

I'm still pretty new to swift package manager. I've noticed though that xcode does not list any of the MapLibre headers under the dependency (e.g. compare the filetree under MapLibre to that of Polyline):
Screenshot 2024-06-03 at 15 43 37

Maybe that's related to the header not being found by the documentation generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant