Skip to content

Commit 562b693

Browse files
K0K0V0Kbrumi1024
authored andcommitted
YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs. Contributed by Bence Kosztolnik.
1 parent fba46aa commit 562b693

29 files changed

+260
-252
lines changed

LICENSE-binary

+1-1
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/bootstrap.min.js
427427
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
428428
hadoop-tools/hadoop-sls/src/main/html/css/bootstrap.min.css
429429
hadoop-tools/hadoop-sls/src/main/html/css/bootstrap-responsive.min.css
430-
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.10.18/*
430+
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.11.5/*
431431
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery
432432
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js
433433
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/resources/TERMINAL

LICENSE.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/bootstrap.min.js
252252
hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
253253
hadoop-tools/hadoop-sls/src/main/html/css/bootstrap.min.css
254254
hadoop-tools/hadoop-sls/src/main/html/css/bootstrap-responsive.min.css
255-
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.10.18/*
255+
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.11.5/*
256256
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery
257257
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js
258258
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/resources/TERMINAL

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,12 @@
247247
<exclude>src/main/resources/webapps/test/.keep</exclude>
248248
<exclude>src/main/resources/webapps/proxy/.keep</exclude>
249249
<exclude>src/main/resources/webapps/node/.keep</exclude>
250-
<exclude>src/main/resources/webapps/static/dt-1.10.18/css/jquery.dataTables.css</exclude>
251-
<exclude>src/main/resources/webapps/static/dt-1.10.18/css/custom_datatable.css</exclude>
252-
<exclude>src/main/resources/webapps/static/dt-1.10.18/css/jui-dt.css</exclude>
253-
<exclude>src/main/resources/webapps/static/dt-1.10.18/css/demo_table.css</exclude>
254-
<exclude>src/main/resources/webapps/static/dt-1.10.18/images/Sorting icons.psd</exclude>
255-
<exclude>src/main/resources/webapps/static/dt-1.10.18/js/jquery.dataTables.min.js</exclude>
250+
<exclude>src/main/resources/webapps/static/dt-1.11.5/css/jquery.dataTables.css</exclude>
251+
<exclude>src/main/resources/webapps/static/dt-1.11.5/css/custom_datatable.css</exclude>
252+
<exclude>src/main/resources/webapps/static/dt-1.11.5/css/jui-dt.css</exclude>
253+
<exclude>src/main/resources/webapps/static/dt-1.11.5/css/demo_table.css</exclude>
254+
<exclude>src/main/resources/webapps/static/dt-1.11.5/images/Sorting icons.psd</exclude>
255+
<exclude>src/main/resources/webapps/static/dt-1.11.5/js/jquery.dataTables.min.js</exclude>
256256
<exclude>src/main/resources/webapps/static/jt/jquery.jstree.js</exclude>
257257
<exclude>src/main/resources/webapps/static/jquery/jquery-ui-1.13.2.custom.min.js</exclude>
258258
<exclude>src/main/resources/webapps/static/jquery/jquery-3.6.0.min.js</exclude>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/JQueryUI.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ public class JQueryUI extends HtmlBlock {
6565
@Override
6666
protected void render(Block html) {
6767
html.link(root_url("static/jquery/themes-1.9.1/base/jquery-ui.css"))
68-
.link(root_url("static/dt-1.10.18/css/jquery.dataTables.css"))
69-
.link(root_url("static/dt-1.10.18/css/jui-dt.css"))
70-
.link(root_url("static/dt-1.10.18/css/custom_datatable.css"))
68+
.link(root_url("static/dt-1.11.5/css/jquery.dataTables.css"))
69+
.link(root_url("static/dt-1.11.5/css/jui-dt.css"))
70+
.link(root_url("static/dt-1.11.5/css/custom_datatable.css"))
7171
.script(root_url("static/jquery/jquery-3.6.0.min.js"))
7272
.script(root_url("static/jquery/jquery-ui-1.13.2.custom.min.js"))
73-
.script(root_url("static/dt-1.10.18/js/jquery.dataTables.min.js"))
73+
.script(root_url("static/dt-1.11.5/js/jquery.dataTables.min.js"))
7474
.script(root_url("static/yarn.dt.plugins.js"))
7575
.script(root_url("static/dt-sorting/natural.js"))
7676
.style("#jsnotice { padding: 0.2em; text-align: center; }",

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.10.18/js/jquery.dataTables.min.js

-184
This file was deleted.
+56-52
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ table.dataTable tfoot th {
3939
table.dataTable thead th,
4040
table.dataTable thead td {
4141
padding: 10px 18px;
42-
border-bottom: 1px solid #111;
42+
border-bottom: 1px solid #111111;
4343
}
4444
table.dataTable thead th:active,
4545
table.dataTable thead td:active {
@@ -48,15 +48,19 @@ table.dataTable thead td:active {
4848
table.dataTable tfoot th,
4949
table.dataTable tfoot td {
5050
padding: 10px 18px 6px 18px;
51-
border-top: 1px solid #111;
51+
border-top: 1px solid #111111;
52+
}
53+
table.dataTable thead .sorting,
54+
table.dataTable thead .sorting_asc,
55+
table.dataTable thead .sorting_desc {
56+
cursor: pointer;
57+
*cursor: hand;
5258
}
5359
table.dataTable thead .sorting,
5460
table.dataTable thead .sorting_asc,
5561
table.dataTable thead .sorting_desc,
5662
table.dataTable thead .sorting_asc_disabled,
5763
table.dataTable thead .sorting_desc_disabled {
58-
cursor: pointer;
59-
*cursor: hand;
6064
background-repeat: no-repeat;
6165
background-position: center right;
6266
}
@@ -76,30 +80,30 @@ table.dataTable thead .sorting_desc_disabled {
7680
background-image: url("../images/sort_desc_disabled.png");
7781
}
7882
table.dataTable tbody tr {
79-
background-color: #ffffff;
83+
background-color: white;
8084
}
8185
table.dataTable tbody tr.selected {
82-
background-color: #B0BED9;
86+
background-color: #b0bed9;
8387
}
8488
table.dataTable tbody th,
8589
table.dataTable tbody td {
8690
padding: 8px 10px;
8791
}
8892
table.dataTable.row-border tbody th, table.dataTable.row-border tbody td, table.dataTable.display tbody th, table.dataTable.display tbody td {
89-
border-top: 1px solid #ddd;
93+
border-top: 1px solid #dddddd;
9094
}
9195
table.dataTable.row-border tbody tr:first-child th,
9296
table.dataTable.row-border tbody tr:first-child td, table.dataTable.display tbody tr:first-child th,
9397
table.dataTable.display tbody tr:first-child td {
9498
border-top: none;
9599
}
96100
table.dataTable.cell-border tbody th, table.dataTable.cell-border tbody td {
97-
border-top: 1px solid #ddd;
98-
border-right: 1px solid #ddd;
101+
border-top: 1px solid #dddddd;
102+
border-right: 1px solid #dddddd;
99103
}
100104
table.dataTable.cell-border tbody tr th:first-child,
101105
table.dataTable.cell-border tbody tr td:first-child {
102-
border-left: 1px solid #ddd;
106+
border-left: 1px solid #dddddd;
103107
}
104108
table.dataTable.cell-border tbody tr:first-child th,
105109
table.dataTable.cell-border tbody tr:first-child td {
@@ -109,27 +113,27 @@ table.dataTable.stripe tbody tr.odd, table.dataTable.display tbody tr.odd {
109113
background-color: #f9f9f9;
110114
}
111115
table.dataTable.stripe tbody tr.odd.selected, table.dataTable.display tbody tr.odd.selected {
112-
background-color: #acbad4;
116+
background-color: #abb9d3;
113117
}
114118
table.dataTable.hover tbody tr:hover, table.dataTable.display tbody tr:hover {
115-
background-color: #f6f6f6;
119+
background-color: whitesmoke;
116120
}
117121
table.dataTable.hover tbody tr:hover.selected, table.dataTable.display tbody tr:hover.selected {
118-
background-color: #aab7d1;
122+
background-color: #a9b7d1;
119123
}
120124
table.dataTable.order-column tbody tr > .sorting_1,
121125
table.dataTable.order-column tbody tr > .sorting_2,
122126
table.dataTable.order-column tbody tr > .sorting_3, table.dataTable.display tbody tr > .sorting_1,
123127
table.dataTable.display tbody tr > .sorting_2,
124128
table.dataTable.display tbody tr > .sorting_3 {
125-
background-color: #fafafa;
129+
background-color: #f9f9f9;
126130
}
127131
table.dataTable.order-column tbody tr.selected > .sorting_1,
128132
table.dataTable.order-column tbody tr.selected > .sorting_2,
129133
table.dataTable.order-column tbody tr.selected > .sorting_3, table.dataTable.display tbody tr.selected > .sorting_1,
130134
table.dataTable.display tbody tr.selected > .sorting_2,
131135
table.dataTable.display tbody tr.selected > .sorting_3 {
132-
background-color: #acbad5;
136+
background-color: #acbad4;
133137
}
134138
table.dataTable.display tbody tr.odd > .sorting_1, table.dataTable.order-column.stripe tbody tr.odd > .sorting_1 {
135139
background-color: #f1f1f1;
@@ -141,28 +145,28 @@ table.dataTable.display tbody tr.odd > .sorting_3, table.dataTable.order-column.
141145
background-color: whitesmoke;
142146
}
143147
table.dataTable.display tbody tr.odd.selected > .sorting_1, table.dataTable.order-column.stripe tbody tr.odd.selected > .sorting_1 {
144-
background-color: #a6b4cd;
148+
background-color: #a6b3cd;
145149
}
146150
table.dataTable.display tbody tr.odd.selected > .sorting_2, table.dataTable.order-column.stripe tbody tr.odd.selected > .sorting_2 {
147-
background-color: #a8b5cf;
151+
background-color: #a7b5ce;
148152
}
149153
table.dataTable.display tbody tr.odd.selected > .sorting_3, table.dataTable.order-column.stripe tbody tr.odd.selected > .sorting_3 {
150-
background-color: #a9b7d1;
154+
background-color: #a9b6d0;
151155
}
152156
table.dataTable.display tbody tr.even > .sorting_1, table.dataTable.order-column.stripe tbody tr.even > .sorting_1 {
153-
background-color: #fafafa;
157+
background-color: #f9f9f9;
154158
}
155159
table.dataTable.display tbody tr.even > .sorting_2, table.dataTable.order-column.stripe tbody tr.even > .sorting_2 {
156-
background-color: #fcfcfc;
160+
background-color: #fbfbfb;
157161
}
158162
table.dataTable.display tbody tr.even > .sorting_3, table.dataTable.order-column.stripe tbody tr.even > .sorting_3 {
159-
background-color: #fefefe;
163+
background-color: #fdfdfd;
160164
}
161165
table.dataTable.display tbody tr.even.selected > .sorting_1, table.dataTable.order-column.stripe tbody tr.even.selected > .sorting_1 {
162-
background-color: #acbad5;
166+
background-color: #acbad4;
163167
}
164168
table.dataTable.display tbody tr.even.selected > .sorting_2, table.dataTable.order-column.stripe tbody tr.even.selected > .sorting_2 {
165-
background-color: #aebcd6;
169+
background-color: #adbbd6;
166170
}
167171
table.dataTable.display tbody tr.even.selected > .sorting_3, table.dataTable.order-column.stripe tbody tr.even.selected > .sorting_3 {
168172
background-color: #afbdd8;
@@ -171,22 +175,22 @@ table.dataTable.display tbody tr:hover > .sorting_1, table.dataTable.order-colum
171175
background-color: #eaeaea;
172176
}
173177
table.dataTable.display tbody tr:hover > .sorting_2, table.dataTable.order-column.hover tbody tr:hover > .sorting_2 {
174-
background-color: #ececec;
178+
background-color: #ebebeb;
175179
}
176180
table.dataTable.display tbody tr:hover > .sorting_3, table.dataTable.order-column.hover tbody tr:hover > .sorting_3 {
177-
background-color: #efefef;
181+
background-color: #eeeeee;
178182
}
179183
table.dataTable.display tbody tr:hover.selected > .sorting_1, table.dataTable.order-column.hover tbody tr:hover.selected > .sorting_1 {
180-
background-color: #a2aec7;
184+
background-color: #a1aec7;
181185
}
182186
table.dataTable.display tbody tr:hover.selected > .sorting_2, table.dataTable.order-column.hover tbody tr:hover.selected > .sorting_2 {
183-
background-color: #a3b0c9;
187+
background-color: #a2afc8;
184188
}
185189
table.dataTable.display tbody tr:hover.selected > .sorting_3, table.dataTable.order-column.hover tbody tr:hover.selected > .sorting_3 {
186-
background-color: #a5b2cb;
190+
background-color: #a4b2cb;
187191
}
188192
table.dataTable.no-footer {
189-
border-bottom: 1px solid #111;
193+
border-bottom: 1px solid #111111;
190194
}
191195
table.dataTable.nowrap th, table.dataTable.nowrap td {
192196
white-space: nowrap;
@@ -278,6 +282,7 @@ table.dataTable tbody td.dt-body-nowrap {
278282
table.dataTable,
279283
table.dataTable th,
280284
table.dataTable td {
285+
-webkit-box-sizing: content-box;
281286
box-sizing: content-box;
282287
}
283288

@@ -320,25 +325,25 @@ table.dataTable td {
320325
text-decoration: none !important;
321326
cursor: pointer;
322327
*cursor: hand;
323-
color: #333 !important;
328+
color: #333333 !important;
324329
border: 1px solid transparent;
325330
border-radius: 2px;
326331
}
327332
.dataTables_wrapper .dataTables_paginate .paginate_button.current, .dataTables_wrapper .dataTables_paginate .paginate_button.current:hover {
328-
color: #333 !important;
333+
color: #333333 !important;
329334
border: 1px solid #979797;
330335
background-color: white;
331-
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%, white), color-stop(100%, #dcdcdc));
336+
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%, white), color-stop(100%, gainsboro));
332337
/* Chrome,Safari4+ */
333-
background: -webkit-linear-gradient(top, white 0%, #dcdcdc 100%);
338+
background: -webkit-linear-gradient(top, white 0%, gainsboro 100%);
334339
/* Chrome10+,Safari5.1+ */
335-
background: -moz-linear-gradient(top, white 0%, #dcdcdc 100%);
340+
background: -moz-linear-gradient(top, white 0%, gainsboro 100%);
336341
/* FF3.6+ */
337-
background: -ms-linear-gradient(top, white 0%, #dcdcdc 100%);
342+
background: -ms-linear-gradient(top, white 0%, gainsboro 100%);
338343
/* IE10+ */
339-
background: -o-linear-gradient(top, white 0%, #dcdcdc 100%);
344+
background: -o-linear-gradient(top, white 0%, gainsboro 100%);
340345
/* Opera 11.10+ */
341-
background: linear-gradient(to bottom, white 0%, #dcdcdc 100%);
346+
background: linear-gradient(to bottom, white 0%, gainsboro 100%);
342347
/* W3C */
343348
}
344349
.dataTables_wrapper .dataTables_paginate .paginate_button.disabled, .dataTables_wrapper .dataTables_paginate .paginate_button.disabled:hover, .dataTables_wrapper .dataTables_paginate .paginate_button.disabled:active {
@@ -350,19 +355,19 @@ table.dataTable td {
350355
}
351356
.dataTables_wrapper .dataTables_paginate .paginate_button:hover {
352357
color: white !important;
353-
border: 1px solid #111;
358+
border: 1px solid #111111;
354359
background-color: #585858;
355-
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%, #585858), color-stop(100%, #111));
360+
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%, #585858), color-stop(100%, #111111));
356361
/* Chrome,Safari4+ */
357-
background: -webkit-linear-gradient(top, #585858 0%, #111 100%);
362+
background: -webkit-linear-gradient(top, #585858 0%, #111111 100%);
358363
/* Chrome10+,Safari5.1+ */
359-
background: -moz-linear-gradient(top, #585858 0%, #111 100%);
364+
background: -moz-linear-gradient(top, #585858 0%, #111111 100%);
360365
/* FF3.6+ */
361-
background: -ms-linear-gradient(top, #585858 0%, #111 100%);
366+
background: -ms-linear-gradient(top, #585858 0%, #111111 100%);
362367
/* IE10+ */
363-
background: -o-linear-gradient(top, #585858 0%, #111 100%);
368+
background: -o-linear-gradient(top, #585858 0%, #111111 100%);
364369
/* Opera 11.10+ */
365-
background: linear-gradient(to bottom, #585858 0%, #111 100%);
370+
background: linear-gradient(to bottom, #585858 0%, #111111 100%);
366371
/* W3C */
367372
}
368373
.dataTables_wrapper .dataTables_paginate .paginate_button:active {
@@ -409,7 +414,7 @@ table.dataTable td {
409414
.dataTables_wrapper .dataTables_info,
410415
.dataTables_wrapper .dataTables_processing,
411416
.dataTables_wrapper .dataTables_paginate {
412-
color: #333;
417+
color: #333333;
413418
}
414419
.dataTables_wrapper .dataTables_scroll {
415420
clear: both;
@@ -418,22 +423,21 @@ table.dataTable td {
418423
*margin-top: -1px;
419424
-webkit-overflow-scrolling: touch;
420425
}
421-
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > thead > tr > th, .dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > thead > tr > td, .dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > tbody > tr > th, .dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > tbody > tr > td {
426+
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody th, .dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody td {
422427
vertical-align: middle;
423428
}
424-
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > thead > tr > th > div.dataTables_sizing,
425-
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > thead > tr > td > div.dataTables_sizing, .dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > tbody > tr > th > div.dataTables_sizing,
426-
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody > table > tbody > tr > td > div.dataTables_sizing {
429+
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody th > div.dataTables_sizing,
430+
.dataTables_wrapper .dataTables_scroll div.dataTables_scrollBody td > div.dataTables_sizing {
427431
height: 0;
428432
overflow: hidden;
429433
margin: 0 !important;
430434
padding: 0 !important;
431435
}
432436
.dataTables_wrapper.no-footer .dataTables_scrollBody {
433-
border-bottom: 1px solid #111;
437+
border-bottom: 1px solid #111111;
434438
}
435-
.dataTables_wrapper.no-footer div.dataTables_scrollHead table.dataTable,
436-
.dataTables_wrapper.no-footer div.dataTables_scrollBody > table {
439+
.dataTables_wrapper.no-footer div.dataTables_scrollHead table,
440+
.dataTables_wrapper.no-footer div.dataTables_scrollBody table {
437441
border-bottom: none;
438442
}
439443
.dataTables_wrapper:after {

0 commit comments

Comments
 (0)