Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node version limit in package.json #335

Closed
hanc2006 opened this issue Dec 23, 2018 · 3 comments
Closed

node version limit in package.json #335

hanc2006 opened this issue Dec 23, 2018 · 3 comments

Comments

@hanc2006
Copy link

This is more a technical question than a issue. Is there a reason why the node server version is limited?

"engines": {
"node": ">=6 <7"
},

I ask because I installed tileserver-gl with node server version 8.12 and I wanted to understand if the imposed node version limit in packages.json was connected to some performance problem encountered with the new version of node server.

Thank you

@petrsloup
Copy link
Member

Before #333, Node v8+ was not supported (missing precompiled binaries).

Now, node v8 might now be usable without any issues, but v6 is still better tested.

But we should update the package.json relatively soon if it turns out that everything is compatible with node v8.

@baptistemanson
Copy link

baptistemanson commented Jan 15, 2019

The unit tests are green on node 10+.
In the current state, the lib doesn't install on macosx 10.9+ anymore:

  • the latest canvas lib available for node 6 relies on libstd++ which is deprecated and not available by default.

We will be testing on node 10+ the lib and keep you posted!

@baptistemanson
Copy link

Under node 8 everything works. Unit tests and the the app with the demo data.

Under node 10, the rasterization segfaults due to mapbox/mapbox-gl-native#12252
The rest is okay.

It is better NOT to upgrade past node 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants