Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid signature generation with double encoding #29

Open
justinfenn opened this issue May 30, 2012 · 2 comments
Open

Invalid signature generation with double encoding #29

justinfenn opened this issue May 30, 2012 · 2 comments

Comments

@justinfenn
Copy link

Using these settings, oauth-requests (with header_auth=True) and this oauth signer produce different signatures:

url: http://api.v3.factual.com/multi
parameters: queries=%7B%22query1%22%3A%22%2Ft%2Fplaces%3Ffilters%3D%257B%2522postcode%2522%253A%252290067%2522%257D%22%2C%22query2%22%3A%22%2Ft%2Fplaces%2Ffacets%3Ffilters%3D%257B%2522postcode%2522%253A%252290067%2522%257D%26select%3Dcategory%22%7D
consumer key: key
consumer secret: secret
# token and token secret are blank
timestamp: 1338404204
nonce: 38585129

The signer produces this oauth_signature "+1S2b8kxgOvJAUV90QjbYeB1i7k=" while oauth-requests produces "MWH9o1cwUOMhmrIpybbrsdi/eME=".

However, changing just the following settings seems to work.

parameters: queries=%7B%22query1%22%3A+%22%2Ft%2Fplaces%3Fq%3Dsushi%22%7D
nonce: 2555196

In this case both tools produce this signature: "tvSvg9hjL4ijuMT309h8EAVo44c=".

I'm not certain this is actually caused by the double url encoding, but after running a few tests that seems to be the trigger.

@maraujop
Copy link
Owner

Hi Justin,

I will try to look at this as soon as possible, looks like the problem is what you described. I willl try to work with factual API a test and a fix for it. Hopefully this weekend the farthest.

Cheers,
Miguel

@justinfenn
Copy link
Author

Hi Miguel,

Thanks for looking into this. Has there been any recent progress on the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants