Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up confusing DigitsCollection name #23

Open
marc1uk opened this issue Oct 13, 2018 · 1 comment
Open

Clean up confusing DigitsCollection name #23

marc1uk opened this issue Oct 13, 2018 · 1 comment

Comments

@marc1uk
Copy link
Owner

marc1uk commented Oct 13, 2018

The WCSimWCDigitsCollection created by WCSimWCPMT is constructed in the WCSimWCPMT::Digitize function, with 2 names: "WCDigitizedCollectionPMT", declared in the Digitize() call, and "WCRawPMTSignalCollection" declared in the WCSimWCPMT constructor.

Both are passed as arguments when instantiating the WCSimWCDigitsCollection, apparently setting the 'DetName' or 'DMname', and 'ColName' of the DigitsCollection respectively.
The ColName (or collection name) can be used by the G4DigiManager to retrieve the digits collection. The purpose of the DetName variable in the DigitsCollection is unknown, and does not appear to ever be used.

The digit and hit collections are already complicated enough, and giving the same collection two names only further obfuscates things. As per other DigitsCollections, just use "WCRawPMTSignalCollection" for both ColName and DetName, to make things (somewhat) clearer.

@marc1uk
Copy link
Owner Author

marc1uk commented Oct 13, 2018

confirm this doesn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant