Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row#SetRowValue is not considering projection #326

Open
unrealhoang opened this issue Dec 9, 2024 · 1 comment
Open

Row#SetRowValue is not considering projection #326

unrealhoang opened this issue Dec 9, 2024 · 1 comment

Comments

@unrealhoang
Copy link

go-duckdb/row.go

Lines 32 to 37 in 51311da

func (r Row) SetRowValue(colIdx int, val any) error {
if !r.IsProjected(colIdx) {
return nil
}
return r.chunk.SetValue(colIdx, int(r.r), val)
}

Also I see that this function is not being used anywhere, maybe remove it so people not use it mistakenly instead of SetRowValue[T].

@unrealhoang
Copy link
Author

also currently there's no way to set row value to null, SetRowValue[*int64](row, colIdx, nil) will raise a cast error: cannot cast *int64 to int64, and returning error to FillRow callback will segfault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant