Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTS unpack functions #14

Open
aaronbojarski opened this issue Jun 2, 2023 · 0 comments
Open

NTS unpack functions #14

aaronbojarski opened this issue Jun 2, 2023 · 0 comments

Comments

@aaronbojarski
Copy link
Contributor

aaronbojarski commented Jun 2, 2023

I see. So the other question would then be, whether it wouldn't actually be cleaner to get rid of pos as a parameter of method unpack and to call it with the minimal slice necessary for its job like, e.g., eh.unpack(b[pos:pos + 4]) and x.unpack(b[pos + 4:pos + int(eh.Length)]). But maybe that's also something for a future iteration of this package.

Originally posted by @marcfrei in #12 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant