Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

actually requires django-rest-framework 2.4.0 #221

Closed
fleur opened this issue Feb 28, 2015 · 5 comments
Closed

actually requires django-rest-framework 2.4.0 #221

fleur opened this issue Feb 28, 2015 · 5 comments

Comments

@fleur
Copy link

fleur commented Feb 28, 2015

Hey there. FYI. Django-rest-swagger uses the django-rest-framework's default setting of VIEW_DESCRIPTION_FUNCTION which didn't get put in django-rest-framework until 2.4.0.

@ariovistus
Copy link
Contributor

whoops, thanks

@ariovistus
Copy link
Contributor

wait, if that's the case, why isn't the build with drf 2.3.8 screaming at me?

@ariovistus
Copy link
Contributor

definitely fails with drf 2.3.7. would you be terribly upset if we just officially dropped support for >2.3.8?

@fleur
Copy link
Author

fleur commented Mar 1, 2015

Because VIEW_DESCRIPTION_FUNCTION first made it into 2.3.8, not 2.4.0. My mistake. 2.3.8 is what it actually requires. There must be a better way to link to this, but I don't know it. encode/django-rest-framework@d07dae6#diff-f9716c39348a77db61afdaa2ed35cd87
Also the commit right after this one sets a default for it.

@fleur
Copy link
Author

fleur commented Mar 1, 2015

What I figured was the only thing that would change is the version in the README, which might save someone else a few hours. So no, I wouldn't be terribly upset. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants