Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add support for commands history (up/down arrows) #6

Open
marcinbor85 opened this issue Jul 5, 2021 · 4 comments
Open

[Feature] Add support for commands history (up/down arrows) #6

marcinbor85 opened this issue Jul 5, 2021 · 4 comments

Comments

@marcinbor85
Copy link
Owner

No description provided.

@GhostFire90
Copy link
Contributor

@marcinbor85 Are you working on this? If you arent I'd love to contribute, I have a question abt the input buffer however

@RoStCode
Copy link
Contributor

Hi @GhostFire90
I´ve implemented this in https://github.com/RoStCode/microshell/tree/issue6_cmd_history and it is working good in a "production environment". However, I would say that code is not yet ready for prime time. Some unit tests are missing and code could be improved. Feel free to try it out and suggest improvements.

@GhostFire90
Copy link
Contributor

@RoStCode Sounds good! thank you for the reply, do you have specific src files you worked in for it? im curious how you implemented it

@RoStCode
Copy link
Contributor

What do you mean? All code is visible in the branch linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcinbor85 @RoStCode @GhostFire90