-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposition for alternative property for InProgressDataDate column in MARCO-BOLO_Metadata_Dataset_Record_WP5 #28
Comments
fine by me - would need to change for all the WP spreadsheets, mind |
except ... these googlesheets do not need to be transformed, laurian. only the URIs they refer to. At some point we may (again) ask for metadata to be added here that will need to be transformed, but for now, not. |
only the value in cell D8 of the 'Column descriptions' tab would have to be changed (no other values need changing) - and this would only be to be aligned with what is actually used in the triples (but not required for things to work/not break) |
Are we OK here? In that, the "in progress date" is not something you need to read into your templates. Can I close this? |
with #36 duplicate keys issue disappeared on its own however, https://schema.org/additionalProperty is not expected to be used on Dataset, dataset-catalogue/scripts/tests/templates/gsheet.jsonld.ldt.j2 Lines 404 to 406 in 9e95ff3
@kmexter , @pieterprovoost or @pbuttigieg could you indicate whether schema.org-model needs to be rigidly followed? and which predicate is preferred in this case? |
yeh, this is for @pieterprovoost or @pbuttigieg - not my expertise. I suggest that you two P's go thru the list of properties - col D of https://docs.google.com/spreadsheets/d/1jH8Gp50y9w_SsoFELYTKV6ohPlkO3nqm/edit?gid=115560455#gid=115560455 for example - and double check them |
It does validate and ODIS does use it on other types (we so reason for limiting its range). That being said, there may be a better way.
"For data that are still in progress; please fill in an approximate date (YYYY-MM) you expect them to be published" This says to me that schema: If the value of creativeWorkStatus uses a DefinedTerm type, one can add the expected date of release in a description (or other) property of DefinedTerm. One could just use text and say something like "Incomplete. Expected release on ..." but this isn't great. |
MARCO-BOLO_Metadata_Dataset_Record_WP5
Duplicate keys are not allowed in json(-ld)
--> meaning that the schema.org equivalent property of 'additionalProperty' for the columns "InProgressDataDate" and "EVDescription" needs to change for one these columns;
--> propose to change 'additionalProperty' into 'datePublished' for "InProgressDataDate"
Is this okay?
The text was updated successfully, but these errors were encountered: