Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb-and-k support #89

Closed
Globegitter opened this issue Nov 20, 2019 · 4 comments
Closed

pb-and-k support #89

Globegitter opened this issue Nov 20, 2019 · 4 comments

Comments

@Globegitter
Copy link

It would be nice to be able to fully utilise kotlin features, also for the protobuf creation itself. What do you think of supporting https://github.com/cretz/pb-and-k - would this be something feasible/useful?

@marcoferrer
Copy link
Owner

I have no opposition to supporting pb-and-k. I was actually very interested in it. Originally I was working on a poc to support it but the author mentioned here that he didnt have capacity anymore to support pb-and-k.

The other full kotlin protobuf alternative is kotlinx serialization. I had placed a hold on integration with that project since it was still lacking support for some proto3 features like oneof at the time.

@Globegitter
Copy link
Author

Globegitter commented Nov 21, 2019

Thanks for the quick response, there is also wire, but it also has only limited proto3 support. Is the issue you are referring to: Kotlin/kotlinx.serialization#67?

But either way the reasoning makes total sense for not supporting pb-and-k, so the issue can be closed.

Hopefully some of the other options will progress over the coming months.

@Globegitter
Copy link
Author

Globegitter commented Jan 9, 2020

@marcoferrer Turns out an organisation has forked pb-and-k and is now maintaining it: https://github.com/streem/pbandk could be worth taking a look at. What do you think?

@RdeWilde
Copy link

RdeWilde commented Feb 5, 2021

Also kotlinx serialization has progressed. We should be good to go. Where to start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants