Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method signature support to adhere to spec #92

Closed
marcoferrer opened this issue Dec 3, 2019 · 0 comments · Fixed by #99
Closed

Update method signature support to adhere to spec #92

marcoferrer opened this issue Dec 3, 2019 · 0 comments · Fixed by #99

Comments

@marcoferrer
Copy link
Owner

The current implementation of support for method signature options is compliant with the specification defined in googleapis/api-common-protos/client.proto#L79

The following changes need to be made to become spec compliant.

  • Each instance of a method signature annotation is to be treated as a target signature
  • The fields to include in the signature are to be defined as a comma delimited string

The current implementation incorrectly assumes that there is only ever one target method signature to implement. It also collects all of the signature annotation entries on a method and treats them as the fields to output in the target signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant