Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for environments #9

Closed
kuoruan opened this issue Jan 4, 2024 · 4 comments
Closed

[Feature Request] Add support for environments #9

kuoruan opened this issue Jan 4, 2024 · 4 comments

Comments

@kuoruan
Copy link

kuoruan commented Jan 4, 2024

See: https://github.com/browserslist/browserslist?tab=readme-ov-file#configuring-for-different-environments

Config files like:

[production]
> 1%
not dead

[modern]
last 1 chrome version
last 1 firefox version

[ssr]
node 12
@marcofugaro
Copy link
Owner

It already works, I added a test for it.

Does it not work for you?

@kuoruan
Copy link
Author

kuoruan commented Jan 4, 2024

Yes, it works.
But it will be better add some option like babel's browserslistEnv
https://babeljs.io/docs/babel-preset-env#browserslistenv

@marcofugaro
Copy link
Owner

Hmm, ok there are now two ways you can specify this option.

Either with BROWSERSLIST_ENV like this:

BROWSERSLIST_ENV=ssr node esbuild.js

or with the options parameter like this:

browserslistToEsbuild(undefined, { env: 'ssr' })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants