Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on loading since sbcl 2.4.0 (and warnings in 2.3.3) #15

Open
ajberkley opened this issue May 27, 2024 · 1 comment
Open

Error on loading since sbcl 2.4.0 (and warnings in 2.3.3) #15

ajberkley opened this issue May 27, 2024 · 1 comment

Comments

@ajberkley
Copy link

In code/sbcl.lisp, you need &rest t in the deftransform, not &rest * or you get a WARNING at compile time for sbcl 2.3.3 (I'm not sure when the change occurred).

More importantly, since sbcl 2.4.0 sb-pcl::%no-primary-method has disappeared and fast-generic-functions does not load anymore.

See sbcl/sbcl@347df80 for the change.

I think it is sufficient to only install %no-primary-method if the symbol sb-pcl::%no-primary-method exists, but I haven't read through this carefully or understood what it is trying to do.

If you are still around maintaining this package, I can create a PR for the changes (so far I haven't seen any response to the issues that mention this from Jan of this year).

Thank you!

@ajberkley
Copy link
Author

ajberkley commented Jun 9, 2024

See PR #16 for a fix that works for me for at least sbcl 2.3.x and 2.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant