Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic: Warn if [name]Outlet is used in connect() #288

Open
marcoroth opened this issue May 22, 2024 · 0 comments
Open

Diagnostic: Warn if [name]Outlet is used in connect() #288

marcoroth opened this issue May 22, 2024 · 0 comments
Labels
diagnostic Feature that implements a `textDocument/diagnostic` request. enhancement New feature or request feature Issue that implements a new feature.

Comments

@marcoroth
Copy link
Owner

Stimulus cannot guarantee that an outlet is available in the connect() method. We can add a diagnostic to let people know that it might have undesired behavior and that they should use the [name]OutletConnected() callback Stimulus provides.

Inspired by @scottwater's tweet: https://twitter.com/scottw/status/1793071577669734619
@marcoroth marcoroth added enhancement New feature or request feature Issue that implements a new feature. diagnostic Feature that implements a `textDocument/diagnostic` request. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostic Feature that implements a `textDocument/diagnostic` request. enhancement New feature or request feature Issue that implements a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcoroth