Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding api and hook config to default excludes #58

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

mathom
Copy link
Contributor

@mathom mathom commented Jun 10, 2016

I've noticed that the default exclude doesn't prevent the api and hook config files from being included in the zip. If this isn't intentional, this PR adds them. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.028% when pulling eb7bd08 on mathom:newconf into d41bade on marcy-terui:master.

@marcy-terui
Copy link
Owner

Thank you for your repoting 👍

I'm sorry for confusing you.
.lamvery.exclude.yml is for testing on this repository.

The default settings are written here. (Also missing here too...)

lamvery/lamvery/config.py

Lines 267 to 272 in c090a60

def get_default_exclude(self):
return [
'^{}$'.format(re.escape(self._file)),
'^{}$'.format(re.escape(self.get_event_file())),
'^{}$'.format(re.escape(self.get_secret_file())),
'^{}$'.format(re.escape(self.get_exclude_file()))]

Can you fix it and add a commit to this request?

Thanks!

@mathom
Copy link
Contributor Author

mathom commented Jun 10, 2016

Whoops, I missed that. I'll fix it up.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.028% when pulling 893453b on mathom:newconf into d41bade on marcy-terui:master.

@mathom
Copy link
Contributor Author

mathom commented Jun 10, 2016

Should be good to go now. I've tested it on a new project this time 😰

@marcy-terui
Copy link
Owner

Perfect!! Thanks!!

@marcy-terui marcy-terui merged commit 1665e45 into marcy-terui:master Jun 10, 2016
@marcy-terui
Copy link
Owner

Released as 0.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants