fix: #242 exported worklet functions are undefined #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #242
The problem is with the reanimated/worklets babel plugin, and has been reported here:
The babel plugin that transpiles our typescript code transforms the typescript to this commonjs code:
As it can be seen the exports / usage of the variable happens before the function is declared, which causes the worklet function to be undefined (as reported in the REA issue above).
Solution
I checked out rnskia is doing it, and they use const and anonymous functions, which is indeed working as the export then happens after the declaration:
So from now on we must export all worklet functions as const arrow functions
Alternative solutions
I tried to do it as reanimated and remove the CommonJS support, and only create a ES module. However, that didn't work due to some react native bugs, where it can't find the codegen component anymore.