Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features proposal #8

Open
kostasx opened this issue Jun 28, 2021 · 0 comments
Open

Additional features proposal #8

kostasx opened this issue Jun 28, 2021 · 0 comments

Comments

@kostasx
Copy link

kostasx commented Jun 28, 2021

  • Put the instructions (README) in the front page for the users.
  • Add a loading indicator on the Cat, Dog, Wild Animal pages so that the users understand that the blank page they see will be loaded with images after a while
  • The ProgressBarCat, ProgressBarDog, ProgressBarAnimal look like they share most of the code. It's probably a case of DRY here. It would be nice to have an abstract component to handle cats, dogs, wild animals and whatever new species might be added in the near future (e.g. decent human beings). Same goes for ImageGridCat, ImageGridDog, ImageGridAnimal, the hooks useStorage* and Cat.js, Dog.js WildAnimal.js. They all look that they can be re-used. The point is that if your app needs to scale, e.g. add 3 more animals, you will be repeating most of the code, writing, copying, pasting which involves a higher risk of making mistakes and of course what would happen if you need to change all the ImageGrids? Will you have to change 6 different Components? That's why Composability in React is the key to a well structure and extensible app.
  • Display the number on the screen along with speech synthesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant