You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With commit d14c1c6, this fixes the bqplot styling issue, but introduces a conflict with our main front-end css. Specifically, adding the rel="stylesheet" to the voila/static/theme-light.css causes the Voila styling to override the default styling of the main site. I haven't dug into the css to see which components are actually in conflict.
Arguably, this could just be details in what we have set on sites that can be tweaked or ironed out by us. But in principle, I think we don't want notebook stylesheets to override site stylesheets as much as possible. This especially applies, for example, to companies that have finely-tuned, controlled, stylesheets for branding but who still wish to embed content via Voila. I don't know what all this particular Voila styling controls, but I imagine it should pertain to all widgets embedded on the page, but leave the rest of the page styling to any existing stylesheets.
The text was updated successfully, but these errors were encountered:
I was able to sort of fix the issue on our end by tweaking our body styling from body to a unique .asb-body class. There are still other small discrepancies. But this solution may not be available for everyone. It still might be worth exploring other solutions.
With commit d14c1c6, this fixes the
bqplot
styling issue, but introduces a conflict with our main front-end css. Specifically, adding therel="stylesheet"
to thevoila/static/theme-light.css
causes the Voila styling to override the default styling of the main site. I haven't dug into the css to see which components are actually in conflict.Arguably, this could just be details in what we have set on sites that can be tweaked or ironed out by us. But in principle, I think we don't want notebook stylesheets to override site stylesheets as much as possible. This especially applies, for example, to companies that have finely-tuned, controlled, stylesheets for branding but who still wish to embed content via Voila. I don't know what all this particular Voila styling controls, but I imagine it should pertain to all widgets embedded on the page, but leave the rest of the page styling to any existing stylesheets.
The text was updated successfully, but these errors were encountered: