-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to backbone 1.4 #3657
Comments
Marionette should work out of the box with 1.4, it works for us. |
Marionette has backbone at a peer dependency, so 1.4.0 will work, however npm/yarn will give a peer dependency warning at install. As backbone has previously had breaking changes in minor updates, we'll probably keep it this way until things are ironed out or are clearly non-breaking. That said, other than the warning there's no reason I can see why using 1.4 wouldn't work now. At some point we'll want to update the peer dependency to include 1.4, but not increase it to remove previous versions. |
Ok, thanks! I'll update the dependency on my side then and see if it breaks in any unexpected ways. |
Hi, I actually had a problem with this. When I did reinstall of all modules in project, BB 1.4 got installed (yes, i reinstalled without lock file), so Babysitter installed 1.3.3 as a peer dependency, which resulted in having two Backbones 1.3.3 and 1.4 - in some webpack modules it was 1.4 and in others 1.3.3. So I had to force the 1.3.3 version of BB back and then reinstall Babysitter. So, would be nice to have dep version upped. Thanks for the tools, anyway! |
From where babysitter is coming? It was removed long time ago |
Hi, |
Backbone 1.4 has been released! Should marionette just work with this new version? Do we need a new marionette release? I see that the package.json pins the version to ~1.3.3, and I guess this means 1.4 is not yet supported?
The text was updated successfully, but these errors were encountered: