Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to backbone 1.4 #3657

Closed
jaapz opened this issue Feb 21, 2019 · 6 comments
Closed

Upgrade to backbone 1.4 #3657

jaapz opened this issue Feb 21, 2019 · 6 comments
Milestone

Comments

@jaapz
Copy link

jaapz commented Feb 21, 2019

Backbone 1.4 has been released! Should marionette just work with this new version? Do we need a new marionette release? I see that the package.json pins the version to ~1.3.3, and I guess this means 1.4 is not yet supported?

@Borming
Copy link

Borming commented Feb 21, 2019

Marionette should work out of the box with 1.4, it works for us.

@paulfalgout
Copy link
Member

Marionette has backbone at a peer dependency, so 1.4.0 will work, however npm/yarn will give a peer dependency warning at install. As backbone has previously had breaking changes in minor updates, we'll probably keep it this way until things are ironed out or are clearly non-breaking. That said, other than the warning there's no reason I can see why using 1.4 wouldn't work now. At some point we'll want to update the peer dependency to include 1.4, but not increase it to remove previous versions.

@jaapz
Copy link
Author

jaapz commented Feb 25, 2019

Ok, thanks! I'll update the dependency on my side then and see if it breaks in any unexpected ways.

@noobiek
Copy link

noobiek commented Mar 2, 2019

Hi,

I actually had a problem with this. When I did reinstall of all modules in project, BB 1.4 got installed (yes, i reinstalled without lock file), so Babysitter installed 1.3.3 as a peer dependency, which resulted in having two Backbones 1.3.3 and 1.4 - in some webpack modules it was 1.4 and in others 1.3.3.

So I had to force the 1.3.3 version of BB back and then reinstall Babysitter. So, would be nice to have dep version upped.

Thanks for the tools, anyway!

@blikblum
Copy link
Collaborator

blikblum commented Mar 2, 2019

From where babysitter is coming? It was removed long time ago

@noobiek
Copy link

noobiek commented Mar 2, 2019

Hi,
Sorry for the confusion. I use the separate Babysitter module from npm.
So yeah, I don't use Marionette (I wish I didn't miss it when I started the project 2+ years ago). I use Bb, Bs and Radio.
Perhaps I should've posted this to the Babysitter repo, but I found this issue and didn't wan't to duplicate. Sorry again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants