Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Folder / Tag / Group sharing #27

Closed
Ninos opened this issue Feb 28, 2018 · 103 comments
Closed

[Feature] Folder / Tag / Group sharing #27

Ninos opened this issue Feb 28, 2018 · 103 comments
Labels
feature A new functionality for the app

Comments

@Ninos
Copy link

Ninos commented Feb 28, 2018

Hey there,
is it possible to share complete folders or tags with a user group? Such feature would be awesome, e.g. for board/marketing/presales/customers groups :-)

PS: Thank you for the great alternative, which is much more integrated into nextcloud.

@Ninos
Copy link
Author

Ninos commented Feb 28, 2018

Oh, seems dublicate of #18. Is there a reason, why you closed this ticket?

@marius-wieschollek
Copy link
Owner

The reason why #18 is closed is that it was just a question.

The feature itself is quite difficult to implement. The way Passwords is built prevents users from accessing any data which they do not own. Sharing works by copying the passwords via a privileged background job. This gets a lot more complicated when the object is shared with a group and even more complicated when it is implicitly shared trough a folder or a tag.

Currently the main focus is fixing bugs, then adding missing single-user functionality and providing better encryption options. After that browser extensions and apps will be updated.
It will be probably 2019 before i have the necessary time for this functionality.

@Ninos
Copy link
Author

Ninos commented Feb 28, 2018

Thanks for feedback. In NC13 the server-side-encryption was chanced so groups sharing is possible without re-encryption. This is possible by using the master-key which lower the security but enhance the usability. I think switching to this new workflow and implementing an optional e2e-encryption (based on nc) should bring enough security and also usability :-)

@Ninos
Copy link
Author

Ninos commented Feb 28, 2018

BTW:
For such feature request you can also ask for donations for faster implementation, see also:
nextcloud/passman#243

@marius-wieschollek marius-wieschollek added feature A new functionality for the app discussion labels Mar 1, 2018
@tezukzai
Copy link

tezukzai commented Mar 3, 2018

This app is just what I have been looking for! Great work.

I second the above. Sharing password folders or tags with circles from the circle app or by LDAP groups would be ideal. I'd be happy to contribute a donation to speed this up.

@pafcioooo
Copy link

pafcioooo commented Mar 10, 2018

Maybe it could be to start with something basic, like sharing to group would result in sharing each password individually to each member of the group. Of course it should work on groups made in nextcloud level, not only password app level (so the ldap groups can be used too).

Similar way we could add folder sharing, so when folder is shared individual passwords are shared.

In both options of course there should be some filed in db to track if the password is group/folder shared.

@Flore-mozfr
Copy link

I second this, very good idea.
My usecase: Scout group, the leaders have each an account on the nextcloud instance. I organize them in groups (cubs, beavers, scouts, rovers...) so they can share with their co-leaders. And in september, we welcome new leaders, some leaders change units (from scouts to rover, for example), so I rearrange the groups.
It would be great to be able to share the passwords the same way, So I don't need to rearrange passwords sharing, just the nextcloud groups.

BTW: I am talking of 30 to 40 users

@PhantomPhreak
Copy link

I'd like to have folder sharing feature too. Sharing a set of passwords that belongs to something will be more convenient than sharing passwords one by one.

@igloo777
Copy link

I agree with @PhantomPhreak, it's very actual if you have a big number of passwords.

@LucyDemooon
Copy link

yes it would be nice we also need an password manager for team but 20 or more user to share one by one is heavy, folder and group share with higher priority pls.
@marius-wieschollek i will pay/spend money to this feature for higher priority

@alexanderdd
Copy link

came here to ask for this, too =)

@marius-wieschollek multiple people have offered financial contributions (@LucyDemooon @tezukzai ). Can you tell us how people can donate?

Also, people over at nextcloud/passman#243 seem to have found some possibility to make it happen..

@marius-wieschollek marius-wieschollek changed the title Group sharing [Feature] Group sharing Aug 27, 2018
@Natureshadow
Copy link

At least two organisations I work with are in need of that, too ;)!

@marius-wieschollek marius-wieschollek changed the title [Feature] Group sharing [Feature] Folder / Tag / Group sharing Sep 27, 2018
@mokkin
Copy link

mokkin commented Dec 5, 2018

For me the same. Group and folder/tag sharing would be really great!
If you are interested in donations, please provide payment credentials such as IBAN or Paypal.

@Ninos
Copy link
Author

Ninos commented Dec 5, 2018

Would also like to donate something if it speeds up the implementation. Just tell us your price, may we can collect some donations :-)

@mokkin
Copy link

mokkin commented Dec 5, 2018

There is an option to collect money via Paypal or on https://www.bountysource.com/
But I think @marius-wieschollek should start this if he accepts this way.

@git001
Copy link

git001 commented Dec 11, 2018

I would also like to donate for this feature.

@clarm060
Copy link

I also Second the ability to Share Folders to groups and/or users. It would allow me to switch my team to this wonderful tool!

@perphilip
Copy link

This would be a great feature indeed, but already allowing to share with groups (specifically circles) would be a great start. Thanks for you work so far!

@grickard
Copy link

grickard commented Apr 11, 2019

I also would be willing to donate if it would push the development of this feature. Another future feature that would be nice would be the ability to send password requests to people. My organization often needs credentials from clients and it would be nice if I could push a secure password request to them and have it automatically added into Passwords. I could see possible security concerns with this though.

@simondaigre
Copy link

I would also like to donate for this feature too.

@Djiock
Copy link

Djiock commented Apr 30, 2019

Hello !
With my company (heavy Nextcloud users) we need a password sharing solution and, using this one personally, I told it's awesome, it's just missing this essential feature...
We're also willing to pay to have it, if that can be done withing the next few months :)

@JulesBalgue
Copy link

JulesBalgue commented Jul 24, 2019

Hi,

We are ready to donate for this feature too.

Hope this feature will comes quickly ! :)

@nomad-lw
Copy link

nomad-lw commented Aug 6, 2019

+1
Would love to see this get implemented.

@ndom91
Copy link

ndom91 commented Aug 12, 2019

+1 critical feature for our organization. Any word if there is any progress on this?

Repository owner deleted a comment from ffuentes Sep 1, 2022
@LokeYourC3PH
Copy link

+1 on the feature, would really enjoy having some Group share function for collaboration or cases where multiple users need to utilize passwords/data for different services.

@mercury1337
Copy link

+1 Using passwords for a club and it would be awesome if we could share folders with groups.

@IARI
Copy link

IARI commented Apr 19, 2023

Thanks for the continued active development on the project.
Considering this issue, It looks as if there has not been any development on the sharing branch.

@marius-wieschollek if could you give us just a very a brief update on your current state of mind regarding this issue, I would be very happy

@FranziskaSom
Copy link

FranziskaSom commented Apr 27, 2023

Hi :)
we are also with you ... where can we donate?

we could use, for example, https://opencollective.com/. would that be something?

see examples for nextcloud support https://opencollective.com/floccus

Best regards to all :)

@Jean-Jaque
Copy link

Same here. Would be happy to donate as we love this plugin !

@PSchewe
Copy link

PSchewe commented Jun 14, 2023

+1

@LokeYourC3PH
Copy link

I started using and integrating Bitwarden into my service. I'd recommend everyone to do so as well and just drop this, it won't happen.

@rlKoekie
Copy link

This feature request is a prime example of open source projects :-)
I suspect @marius-wieschollek is more than happy to have this feature, but he probably has plenty of other things to do with his time. However, this does not have to be a showstopper: this is open source software, anybody can contribute!
Yes, yes, not everybody can code, and probably even fewer of us can code in such a way that it is up to standard for such a security-sensitive topic (keep in mind: doing this in the wrong way could cause major security problems).

For those willing to pay money: check if you know somebody who can take on a project like this, and tell them about the bounties already offered here. The coder-for-hire could then spent a bit of time investigating the project and maybe have a chat with @marius-wieschollek about possible ways of doing this. If that works out smoothly, the coder could then work implementing the feature in an acceptable manner.

TLDR; work with what we have: Marius does not have to do anything for us, and we all could take some form of action if we really wanted to!

@marius-wieschollek : thank you for writing and maintaining this code, I still use it every day!

@mokkin
Copy link

mokkin commented Jun 15, 2023

Thank you for you work @marius-wieschollek and thank you for your words @rlKoekie !
This is exactly my opinion too. Sometimes people have to be reminded to the basics while they are demanding something ;)

@codePau
Copy link

codePau commented Oct 20, 2023

Hi,
I am interested in three different functionalities:

  1. Share one password with a group (1 to many)
  2. Share several passwords with a person (many to 1)
  3. Share several passwords with a group (many to many)

Functionality 1 seemed to be addressed in Issue 311 (#311), which was closed after referencing this conversation (Issue 27). This conversation is about functionality 3, which would be a combination of functionality 1 and 2 so, in my opinion, Issue 311 shouldn't have been closed.
I am happy to give some traction to this. Would anyone be interested in working in functionality 1 or 2? You can drop me a line at pau@pau.company. @marius-wieschollek it would be great to have a conversation with you. Thanks for all the work put on this app.
Thanks everybody!

@cnh003
Copy link

cnh003 commented Nov 17, 2023

First off, I'm not a PHP developer. I'm coming from a C++ world. But as most users of the plugin probably don't understand how complex this is, I'd like to paint a picture of how this could work.

First off: Especially the part of sharing with groups seems rather tricky to me. At some point or another, some user will be granting access to data they don't have access to themselves. If not implemented carefully, this will lead to a potentially disastrous security issue!

Second, for sharing groups, we do NOT want to duplicate the actual data. This WILL become a reference nightmare, especially if we allow users to reshare shared passwords. So, what we instead want to do is: keep the passwords and structures the same, and share the encryption keys.

This can be done with a relatively straightforward concept:

  • Each user and each group has an own public/private key pair
  • Each user has access to all their groups' private keys
  • We have an asymmetrically encrypted key storage, and a symmetrically encrypted password storage
  • Each password is encrypted with a unique key
  • These keys are stored in the key storage, encrypted with a folder key
  • To share, just add another entry in the key storage, encrypted with the recipient's public key

Things to consider:

  • if a share is revoked, all affected keys must be replaced
  • whenever a share is revoked, should we remind the users to change the previously shared passwords?
  • how can we handle granting/revoking access if a user who is not a member of a group adds or removes users from a group?
  • if a user's account password is reset, they lose all access to their data, or their private key is not stored encrypted

The last two points can be addressed by storing a copy of all users' and/or groups' private keys encrypted with a single master key. This master key should then be only shared with admins (i.e. stored encrypted with their respective public keys), and could be used for changing group memberships and/or recovering users' access to their passwords.

If I understand the codebase (from roughly skipping through) correctly, this doesn't only affect sharing, but the way how Passwords stores and accesses data as a whole.

That is why it really takes a lot of effort to implement, and at the same time might make the system a little less secure.

@ssergio-ll
Copy link

Is there any information on whether there has been progress on this feature? I think this app is excellent, but we don't use it because we can't share folders with groups. In our company, it's essential. It's very cumbersome to share the passwords one by one. For now, we use KeePassX locally and synchronize the file with Nextcloud, but if this functionality is implemented, it would be a great advance that I think would give the app enormous power.

@battosai30
Copy link

My advice : don't expect this feature ... I switched to VaultWarden.

@karge-itestra
Copy link

This feature would be very helpful!

@johnnyq
Copy link

johnnyq commented Apr 13, 2024

This would be very useful for us too as we have several departments that need to share passwords

@NikoKS
Copy link

NikoKS commented Jun 25, 2024

Truly need this feature 🙏

@Mululu
Copy link

Mululu commented Jun 28, 2024

Hello Earth to developers?

The folder / tag / group sharing function has been requested for more than 2 years but nothing has happened?

If you can't do it alone, get some help from other developers.

@pReya
Copy link

pReya commented Jun 28, 2024

Hello Earth to developers?

The folder / tag / group sharing function has been requested for more than 2 years but nothing has happened?

If you can't do it alone, get some help from other developers.

You should dial back your tone. No one owes you anything. I suppose you never paid anything for this app. So you'd be better off by saying something like "Thank you for this app, which is already pretty good and I've been using for years, without paying anything".

This GitHub repo is not the primary repo for this plugin. If you really want to get answers, you'd be better off here: https://git.mdns.eu/nextcloud/passwords

@Natureshadow
Copy link

Natureshadow commented Jun 28, 2024 via email

@Mululu
Copy link

Mululu commented Jun 28, 2024

Hello Earth to developers?
The folder / tag / group sharing function has been requested for more than 2 years but nothing has happened?
If you can't do it alone, get some help from other developers.

You should dial back your tone. No one owes you anything. I suppose you never paid anything for this app. So you'd be better off by saying something like "Thank you for this app, which is already pretty good and I've been using for years, without paying anything".

This GitHub repo is not the primary repo for this plugin. If you really want to get answers, you'd be better off here: https://git.mdns.eu/nextcloud/passwords

If you feel attacked by something like this after 2 years of feature requests, something is wrong. You just want to see an answer or some progress. What's wrong with that!?

I'm happy to pay for software, plug-ins, etc. if they meet the basic requirements. And in my opinion, a sharing function for folders, tags and groups is a must, especially in Nextcloud.

Furthermore, I don't use this app because of the missing feature! As soon as this feature is available, I'll be happy to include it in my Nextcloud.

@simaoafonso-pwt
Copy link

Here we go again...

Every time someone comments on this issue, 66 emails go out. This is not the right place to argue about generic software development sustainability. It's pretty clear this is issue is not being worked on, alternatives have been mentioned, comment only if you have something else to add (like a Pull Request).

@marius-wieschollek Can you close this issue to comments, to avoid all the off-topic noise?

PS: I'm unsubscribing anyway, don't @ me.

@johnnyq
Copy link

johnnyq commented Jun 28, 2024

@Mululu we all want the features you want.

you may not be aware and may have thought it was funny but the following comments could and have upset developers and supporters working on this project:

Hello Earth to developers?

and

If you can't do it alone, get some help from other developers. (This one, FOSS Developers don't have time to just reach out to other developers, developers choose to donate their time to projects like this)

No Worries, Just be careful with your words next time that's all.

@marius-wieschollek marius-wieschollek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
@marius-wieschollek
Copy link
Owner

Replaced by #582 & #583. These features will be implemented when anyone who wants them has time to implement them. Until then i recommend you look for a different solution.

Repository owner locked as off-topic and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new functionality for the app
Projects
None yet
Development

No branches or pull requests