-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Folder / Tag / Group sharing #27
Comments
Oh, seems dublicate of #18. Is there a reason, why you closed this ticket? |
The reason why #18 is closed is that it was just a question. The feature itself is quite difficult to implement. The way Passwords is built prevents users from accessing any data which they do not own. Sharing works by copying the passwords via a privileged background job. This gets a lot more complicated when the object is shared with a group and even more complicated when it is implicitly shared trough a folder or a tag. Currently the main focus is fixing bugs, then adding missing single-user functionality and providing better encryption options. After that browser extensions and apps will be updated. |
Thanks for feedback. In NC13 the server-side-encryption was chanced so groups sharing is possible without re-encryption. This is possible by using the master-key which lower the security but enhance the usability. I think switching to this new workflow and implementing an optional e2e-encryption (based on nc) should bring enough security and also usability :-) |
BTW: |
This app is just what I have been looking for! Great work. I second the above. Sharing password folders or tags with circles from the circle app or by LDAP groups would be ideal. I'd be happy to contribute a donation to speed this up. |
Maybe it could be to start with something basic, like sharing to group would result in sharing each password individually to each member of the group. Of course it should work on groups made in nextcloud level, not only password app level (so the ldap groups can be used too). Similar way we could add folder sharing, so when folder is shared individual passwords are shared. In both options of course there should be some filed in db to track if the password is group/folder shared. |
I second this, very good idea. BTW: I am talking of 30 to 40 users |
I'd like to have folder sharing feature too. Sharing a set of passwords that belongs to something will be more convenient than sharing passwords one by one. |
I agree with @PhantomPhreak, it's very actual if you have a big number of passwords. |
yes it would be nice we also need an password manager for team but 20 or more user to share one by one is heavy, folder and group share with higher priority pls. |
came here to ask for this, too =) @marius-wieschollek multiple people have offered financial contributions (@LucyDemooon @tezukzai ). Can you tell us how people can donate? Also, people over at nextcloud/passman#243 seem to have found some possibility to make it happen.. |
At least two organisations I work with are in need of that, too ;)! |
For me the same. Group and folder/tag sharing would be really great! |
Would also like to donate something if it speeds up the implementation. Just tell us your price, may we can collect some donations :-) |
There is an option to collect money via Paypal or on https://www.bountysource.com/ |
I would also like to donate for this feature. |
I also Second the ability to Share Folders to groups and/or users. It would allow me to switch my team to this wonderful tool! |
This would be a great feature indeed, but already allowing to share with groups (specifically circles) would be a great start. Thanks for you work so far! |
I also would be willing to donate if it would push the development of this feature. Another future feature that would be nice would be the ability to send password requests to people. My organization often needs credentials from clients and it would be nice if I could push a secure password request to them and have it automatically added into Passwords. I could see possible security concerns with this though. |
I would also like to donate for this feature too. |
Hello ! |
Hi, We are ready to donate for this feature too. Hope this feature will comes quickly ! :) |
+1 |
+1 critical feature for our organization. Any word if there is any progress on this? |
+1 on the feature, would really enjoy having some Group share function for collaboration or cases where multiple users need to utilize passwords/data for different services. |
+1 Using passwords for a club and it would be awesome if we could share folders with groups. |
Thanks for the continued active development on the project. @marius-wieschollek if could you give us just a very a brief update on your current state of mind regarding this issue, I would be very happy |
Hi :) we could use, for example, https://opencollective.com/. would that be something? see examples for nextcloud support https://opencollective.com/floccus Best regards to all :) |
Same here. Would be happy to donate as we love this plugin ! |
+1 |
I started using and integrating Bitwarden into my service. I'd recommend everyone to do so as well and just drop this, it won't happen. |
This feature request is a prime example of open source projects :-) For those willing to pay money: check if you know somebody who can take on a project like this, and tell them about the bounties already offered here. The coder-for-hire could then spent a bit of time investigating the project and maybe have a chat with @marius-wieschollek about possible ways of doing this. If that works out smoothly, the coder could then work implementing the feature in an acceptable manner. TLDR; work with what we have: Marius does not have to do anything for us, and we all could take some form of action if we really wanted to! @marius-wieschollek : thank you for writing and maintaining this code, I still use it every day! |
Thank you for you work @marius-wieschollek and thank you for your words @rlKoekie ! |
Hi,
Functionality 1 seemed to be addressed in Issue 311 (#311), which was closed after referencing this conversation (Issue 27). This conversation is about functionality 3, which would be a combination of functionality 1 and 2 so, in my opinion, Issue 311 shouldn't have been closed. |
First off, I'm not a PHP developer. I'm coming from a C++ world. But as most users of the plugin probably don't understand how complex this is, I'd like to paint a picture of how this could work. First off: Especially the part of sharing with groups seems rather tricky to me. At some point or another, some user will be granting access to data they don't have access to themselves. If not implemented carefully, this will lead to a potentially disastrous security issue! Second, for sharing groups, we do NOT want to duplicate the actual data. This WILL become a reference nightmare, especially if we allow users to reshare shared passwords. So, what we instead want to do is: keep the passwords and structures the same, and share the encryption keys. This can be done with a relatively straightforward concept:
Things to consider:
The last two points can be addressed by storing a copy of all users' and/or groups' private keys encrypted with a single master key. This master key should then be only shared with admins (i.e. stored encrypted with their respective public keys), and could be used for changing group memberships and/or recovering users' access to their passwords. If I understand the codebase (from roughly skipping through) correctly, this doesn't only affect sharing, but the way how Passwords stores and accesses data as a whole. That is why it really takes a lot of effort to implement, and at the same time might make the system a little less secure. |
Is there any information on whether there has been progress on this feature? I think this app is excellent, but we don't use it because we can't share folders with groups. In our company, it's essential. It's very cumbersome to share the passwords one by one. For now, we use KeePassX locally and synchronize the file with Nextcloud, but if this functionality is implemented, it would be a great advance that I think would give the app enormous power. |
My advice : don't expect this feature ... I switched to VaultWarden. |
This feature would be very helpful! |
This would be very useful for us too as we have several departments that need to share passwords |
Truly need this feature 🙏 |
Hello Earth to developers? The folder / tag / group sharing function has been requested for more than 2 years but nothing has happened? If you can't do it alone, get some help from other developers. |
You should dial back your tone. No one owes you anything. I suppose you never paid anything for this app. So you'd be better off by saying something like "Thank you for this app, which is already pretty good and I've been using for years, without paying anything". This GitHub repo is not the primary repo for this plugin. If you really want to get answers, you'd be better off here: https://git.mdns.eu/nextcloud/passwords |
I suppose you never paid anything for this app.
You should stop assuming things about others. Especially while putting yourself in a position where you tell others how to behave.
|
If you feel attacked by something like this after 2 years of feature requests, something is wrong. You just want to see an answer or some progress. What's wrong with that!? I'm happy to pay for software, plug-ins, etc. if they meet the basic requirements. And in my opinion, a sharing function for folders, tags and groups is a must, especially in Nextcloud. Furthermore, I don't use this app because of the missing feature! As soon as this feature is available, I'll be happy to include it in my Nextcloud. |
Here we go again... Every time someone comments on this issue, 66 emails go out. This is not the right place to argue about generic software development sustainability. It's pretty clear this is issue is not being worked on, alternatives have been mentioned, comment only if you have something else to add (like a Pull Request). @marius-wieschollek Can you close this issue to comments, to avoid all the off-topic noise? PS: I'm unsubscribing anyway, don't @ me. |
@Mululu we all want the features you want. you may not be aware and may have thought it was funny but the following comments could and have upset developers and supporters working on this project: Hello Earth to developers? and If you can't do it alone, get some help from other developers. (This one, FOSS Developers don't have time to just reach out to other developers, developers choose to donate their time to projects like this) No Worries, Just be careful with your words next time that's all. |
Hey there,
is it possible to share complete folders or tags with a user group? Such feature would be awesome, e.g. for board/marketing/presales/customers groups :-)
PS: Thank you for the great alternative, which is much more integrated into nextcloud.
The text was updated successfully, but these errors were encountered: