Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes from non-forked repo #32

Closed
Joelius300 opened this issue Jun 28, 2019 · 1 comment
Closed

Apply changes from non-forked repo #32

Joelius300 opened this issue Jun 28, 2019 · 1 comment

Comments

@Joelius300
Copy link
Contributor

Joelius300 commented Jun 28, 2019

Because I want to use this awesome library in a personal project of mine I downloaded the sources. I wasn't able to find the TimeAxis and there were many errors when updating everything to the latest previews.
For this reason I only copied the source of the actual library and worked on it (fix all the preview errors, lots of refactoring, add lots of properties which are supported by chartJs, ..).

Problem is, I didn't think about giving my adjustments back to the community. I really want to help with this awesome project but I don't know how I can transfer my commits and changes to a pull request here since it's not a fork and has a different folder structure.
I'm currently working on the TimeAxis which I have seen being requested so maybe there's interest for that. It's almost done and as I said, I'd love to let you include it in this repos.

One thing to keep in mind is that I have manually done some of the currently suggested pull request.
The ones I have (partly) done:

Another thing to keep in mind is that I'm almost only working on the Linechart and thus only really testing those properties. I have however reworked a lot of inheritance trees and options which are used for other charts as well. There shouldn't be any sideeffects but it's not tested like most of the library. It seems as many properties that are currently in the master branch weren't tested as well because some simply have the wrong name or are in the wrong place.

Does anyone know how you could import my changes without just copying the code and commiting all at once?

EDIT: my non-forked copy of this repo is here.

@SeppPenner
Copy link
Contributor

I guess, this can be closed since the migration process is already in preparation: Joelius300/ChartJSBlazor#97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants