fix: correct misleading comment about response delivery

andig · claude · andig · commit 1cae3a9ae919 · 2025-07-27T22:02:15.000+02:00
The comment incorrectly stated that responses are broadcast to all sessions, but the implementation actually delivers responses to the specific session identified by sessionID using the activeSessions registry. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/server/streamable_http.go b/server/streamable_http.go
@@ -587,9 +587,7 @@ func (s *StreamableHTTPServer) handleSamplingResponse(w http.ResponseWriter, r *
 	}
 
 	// Find the corresponding session and deliver the response
-	// Note: In a real implementation, we would need to maintain a mapping of sessionID to session instances
-	// For now, we'll use a simplified approach by broadcasting to all active sessions
-	// This is a limitation of the current architecture that would need to be addressed in production
+	// The response is delivered to the specific session identified by sessionID
 	s.deliverSamplingResponse(sessionID, response)
 
 	// Acknowledge receipt

Original file line number	Diff line number	Diff line change
`@@ -587,9 +587,7 @@ func (s StreamableHTTPServer) handleSamplingResponse(w http.ResponseWriter, r `
`587`	`587`	`}`
`588`	`588`
`589`	`589`	`// Find the corresponding session and deliver the response`
`590`		`- // Note: In a real implementation, we would need to maintain a mapping of sessionID to session instances`
`591`		`- // For now, we'll use a simplified approach by broadcasting to all active sessions`
`592`		`- // This is a limitation of the current architecture that would need to be addressed in production`
	`590`	`+ // The response is delivered to the specific session identified by sessionID`
`593`	`591`	`s.deliverSamplingResponse(sessionID, response)`
`594`	`592`
`595`	`593`	`// Acknowledge receipt`