Reverted commit 90f2daf

[nullbio]

Hi Mark, is there a reason 90f2daf was reverted? Thanks.

[nullbio]

Revert here: 25435da

[markbates]

Yes; it was causing significant CPU usage. Reverting this commit brought CPU usage from 100+% to 0.3% on my machine. A lot of users complained about the increased CPU usage.

[nullbio]

You've reverted two commits, the one I'm referring to above seems unrelated to CPU usage. The CPU usage commit you reverted is here: 0b2bb80

[markbates]

That commit needed to be reverted twice due do a bad merge.

…

----------- Mark Bates

On Jul 12, 2017, 9:58 PM -0600, nullbio ***@***.***>, wrote: You've reverted two commits, the one I'm referring to above seems unrelated to CPU usage. The CPU usage commit you reverted is here: 0b2bb80 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[nullbio]

This is somewhat confusing, because you've removed two different features and one is unrelated to CPU usage. Even if it needed to be reverted twice you definitely reverted two separate pieces of code.

Just to clarify again, this is the commit I'm referring to which was merged a while ago: 90f2daf which has now seemingly mistakenly been reverted since it has nothing to do with CPU usage.

The one that seems intentionally reverted is here: 0b2bb80 which has a commit message that refers to huge CPU usage.

[nullbio]

Hey @markbates not sure if you saw my reply. Just trying to get this sorted as quick as possible.

[markbates]

I have. I'm at GopherCon and have been very busy. Sorry. I will try and sort this out tomorrow.

[markbates]

@nullbio ok, it's back in there. sorry about that.

[nullbio]

@markbates Thank you Mark.