Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Deceleration or Migrate #37

Closed
TheSeg opened this issue Jun 8, 2023 · 2 comments · Fixed by #52
Closed

TypeScript: Deceleration or Migrate #37

TheSeg opened this issue Jun 8, 2023 · 2 comments · Fixed by #52
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@TheSeg
Copy link

TheSeg commented Jun 8, 2023

What pain point are you perceiving?.
Even when including @types/marked, including marked-mangle doesn't support TypeScript.

Describe the solution you'd like
As Marked migrates to TypeScript, so should these new Marked support libraries. As they are small projects and the main project will remove the @types/marked dependency, I would request the migration route to reduce the need to add two packages per package.
@UziTech UziTech added enhancement New feature or request help wanted Extra attention is needed labels Jun 9, 2023
@mrsimonemms mrsimonemms mentioned this issue Jun 28, 2023
Merged
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TheSeg
Copy link
Author

TheSeg commented Jun 29, 2023

Thanks folks! Works like a charm and was able to remove my temp shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add typescript declarations
2 participants
@UziTech @TheSeg