Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration - and publish to NPM #1072

Closed
joshbruce opened this issue Feb 23, 2018 · 3 comments
Closed

Continuous Integration - and publish to NPM #1072

joshbruce opened this issue Feb 23, 2018 · 3 comments

Comments

@joshbruce
Copy link
Member

Setting up Circle CI for the first time on a different project...noticed this in one of my references:

      - run:
          name: Publish to NPM
          command: |
            npm config set "//registry.npmjs.org/:_authToken=$NPM_TOKEN"
            npm publish

Publish the package every time we merge into master - seems a bit dangerous, but still. Also thought this might be a good place to chat about all things CI.

@UziTech: Not seeing a way to DM folks in the org. What am I missing there?

@Feder1co5oave
Copy link
Contributor

That's a terrible idea imo

@UziTech
Copy link
Member

UziTech commented Feb 23, 2018

start a private discussion at https://github.com/orgs/markedjs/teams/marked/discussions

This is what something like semantic release would take care of. I don't think it is really necessary.

@joshbruce
Copy link
Member Author

I tend to agree...just wasn't sure how automated we wanted to make things. I can see some benefit under certain use cases. Something to keep in the back or our minds. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants