-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix atx heading and make regex safe #1853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/ou05g5uok |
styfle
approved these changes
Nov 30, 2020
calculuschild
approved these changes
Dec 10, 2020
🎉 This PR is included in version 1.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 11, 2021
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: v1.2.5
Description
Make heading regex safe from redos and pass all atx heading spec tests.
fixes CommonMark spec test 49
possible breaking change: When using the block.heading rule the text provided in capture group 2 will not be trimmed of whitespace.
Since this is only a breaking change to the capture groups this doesn't require a major release but the previous statement should be copied to the release notes.
Contributor
Committer
In most cases, this should be a different person than the contributor.