Allow emStrong regex to consume more characters at once #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small tweak so `emStrong` regex doesn't have to check character-by-character. Try to consume everything up to the delimiter we are checking for.
|
This pull request is being automatically deployed with Vercel (learn more). markedjs – ./🔍 Inspect: https://vercel.com/markedjs-legacy/markedjs/AnvujsPr5PA2XkzbhWXyiu6eBVpD marked-website – ./🔍 Inspect: https://vercel.com/markedjs/marked-website/CXopvjZ7MRVmgcjvuR2yDUPcYBvP |
styfle
approved these changes
Apr 7, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
## [4.0.13](v4.0.12...v4.0.13) (2022-04-08) ### Bug Fixes * allow emStrong regex to consume more characters at once ([#2433](#2433)) ([35583c3](35583c3))
|
🎉 This PR is included in version 4.0.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small tweak so
emStrongregex doesn't have to check character-by-character. Try to consume everything up to the delimiter we are checking for. Should be a small speedup.In response to #2355 .
Compare
Old: https://regex101.com/r/BonHgn/1
New: https://regex101.com/r/C47yws/1
Contributor
Committer
In most cases, this should be a different person than the contributor.