add config option to bin/marked #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Sep 2, 2023
| '~/.marked.json', | ||
| '~/.marked.js', | ||
| '~/.marked/index.js' | ||
| ]; |
There was a problem hiding this comment.
Do we need to consider .mjs and .cjs here too?
It might be better to ship this with only .json first and see if JS support is actually needed.
There was a problem hiding this comment.
I think the .js support will be more useful to be able to include extensions. .mjs and .cjs works for the config option. I don't think we need to include them by default.
styfle
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 7.0.5
Markdown flavor: Marked CLI
Description
Load config with marked cli. This will allow extensions to be used with the marked cli.
TODO
Contributor
Committer
In most cases, this should be a different person than the contributor.