fix: fix emstrong unicode #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Nov 1, 2023
src/Tokenizer.ts
Outdated
| @@ -654,8 +654,7 @@ export class _Tokenizer { | |||
|
|
|||
| // Remove extra characters. *a*** -> *a* | |||
| rLength = Math.min(rLength, rLength + delimTotal + midDelimTotal); | |||
|
|
|||
| const raw = [...src].slice(0, lLength + match.index + rLength + 1).join(''); | |||
| const raw = src.slice(0, lLength + match.index + rLength + [...match[0]][0].length); | |||
There was a problem hiding this comment.
Yes, that is so unicode character length is calculated correctly.
There was a problem hiding this comment.
It might be good to add a comment here since it’s not obvious
styfle
approved these changes
Nov 2, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
## [9.1.5](v9.1.4...v9.1.5) (2023-11-02) ### Bug Fixes * fix emstrong unicode ([#3070](#3070)) ([54b6d1c](54b6d1c))
wallpants
added a commit
to wallpants/pantsdown
that referenced
this pull request
Nov 6, 2023
wallpants
added a commit
to wallpants/pantsdown
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 9.1.4
Description
Fix unicode emstrong demo
Contributor
Committer
In most cases, this should be a different person than the contributor.