-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible addition: store enhancer #70
Comments
Cool, glad to see you did that :) One quick suggestion: rather than a generic name like |
do you feel that's still necessary.. even though I'm using an npm scope? I feel a little silly prefixing all of my npm modules with the scope |
..or are you thinking such a name is more descriptive |
Not thinking about the scope, but rather having a name that's reasonably descriptive. There are, after all, dozens of Redux store enhancers already, which do a variety of different things. "redux-store-enhancer" tells me it's an enhancer, but not what it actually does . "redux-filter-subscriptions-enhancer" tells me it's an enhancer that deals with filtering subscriptions :) |
fair enough.. I'll rename the repo and republish it under the new name to npm |
btw.. I really do appreciate the feedback.. I'm pretty much brand new to redux.. so there's a bit of learning curve :) |
Hi. I submit a pull-request to redux yesterday that you closed with the explanation that the functionality is better suited for an (unofficial) store enhancer.
So, I went ahead and wrote one.
Not sure if it's worthy of a mention, but I just wanted to put it out there.. maybe somebody will find it useful.
The text was updated successfully, but these errors were encountered: