Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duperemove is calling ioctl on the two exact same extent location #331

Open
RustyNova016 opened this issue Nov 22, 2023 · 1 comment
Open

Comments

@RustyNova016
Copy link

I noticed a huge performance hit while trying to dedupe BTRFS snapshots. When Duperemove tries to dedupe 80 copies of a Debian ISO file, it takes a very, very long time, even if it's already deduped.

So I made some tests. I took two ref linked 3GB files, saved their extends, then used Duperemove (no hashfile) on the two files with debug enabled.
During the dedupe phase, multiple ioctl requests have been made.
I then compared the new extends, and they are the exact same as before.

So Duperemove is trying to call ioctl on the same extents, being wasteful, and slowing down deduping large snapshot folders.

@JackSlateur
Copy link
Collaborator

Hello @RustyNova016
You are correct

Sadly, I am working on other things so I will not be able to work on this in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants