Skip to content

Commit 135a2ce

Browse files
Tom Gravesrxin
authored andcommitted
[SPARK-10619] Can't sort columns on Executor Page
should pick into spark 1.5.2 also. https://issues.apache.org/jira/browse/SPARK-10619 looks like this was broken by commit: apache@fb1d06f#diff-b8adb646ef90f616c34eb5c98d1ebd16 It looks like somethings were change to use the UIUtils.listingTable but executor page wasn't converted so when it removed sortable from the UIUtils. TABLE_CLASS_NOT_STRIPED it broke this page. Simply add the sortable tag back in and it fixes both active UI and the history server UI. Author: Tom Graves <tgraves@yahoo-inc.com> Closes apache#9101 from tgravescs/SPARK-10619.
1 parent 390b22f commit 135a2ce

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

core/src/main/scala/org/apache/spark/ui/UIUtils.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import org.apache.spark.ui.scope.RDDOperationGraph
3131
private[spark] object UIUtils extends Logging {
3232
val TABLE_CLASS_NOT_STRIPED = "table table-bordered table-condensed"
3333
val TABLE_CLASS_STRIPED = TABLE_CLASS_NOT_STRIPED + " table-striped"
34+
val TABLE_CLASS_STRIPED_SORTABLE = TABLE_CLASS_STRIPED + " sortable"
3435

3536
// SimpleDateFormat is not thread-safe. Don't expose it to avoid improper use.
3637
private val dateFormat = new ThreadLocal[SimpleDateFormat]() {

core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private[ui] class ExecutorsPage(
6262
val logsExist = execInfo.filter(_.executorLogs.nonEmpty).nonEmpty
6363

6464
val execTable =
65-
<table class={UIUtils.TABLE_CLASS_STRIPED}>
65+
<table class={UIUtils.TABLE_CLASS_STRIPED_SORTABLE}>
6666
<thead>
6767
<th>Executor ID</th>
6868
<th>Address</th>

core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private[ui] class ExecutorTable(stageId: Int, stageAttemptId: Int, parent: Stage
5050
hasBytesSpilled = data.hasBytesSpilled
5151
})
5252

53-
<table class={UIUtils.TABLE_CLASS_STRIPED}>
53+
<table class={UIUtils.TABLE_CLASS_STRIPED_SORTABLE}>
5454
<thead>
5555
<th>Executor ID</th>
5656
<th>Address</th>

streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ private[ui] class BatchPage(parent: StreamingTab) extends WebUIPage("batch") {
443443
}
444444

445445
def generateInputMetadataTable(inputMetadatas: Seq[(Int, String)]): Seq[Node] = {
446-
<table class={SparkUIUtils.TABLE_CLASS_STRIPED}>
446+
<table class={SparkUIUtils.TABLE_CLASS_STRIPED_SORTABLE}>
447447
<thead>
448448
<tr>
449449
<th>Input</th>

0 commit comments

Comments
 (0)