-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
camera distortion #7
Comments
Ah, first paragraph of your readme :p |
Super cool stuff, got it to work. Do you welcome pull requests? I changed show_map.py to use a 3D plot when plotting a 3D map, can send that your way. |
Ok, and a last question. For a single marker, |
Hi @dcnieho, sorry for the late response. I'm glad you got everything to work! Yes a pull request is welcome. The only concern is if it pulls in a massive dependency on a new third party library. As for your second question, I'm not sure. When building maps, an image with a single marker contributes no information to the map. For live inside out tracking, you may end up with a camera frame with just a single marker (or no markers) during camera movement. In these scenarios, it could be a good idea to try both solutions and see which one is more consistent with the previous known camera pose. |
Hi, I find this work very interesting, as i wish to figure out exactly where my markers are on a non-coplanar ArUco board. I am looking through the code, and am wondering the following:
cv2.solvePnP()
but not distortion coefficients. Should i undistort my images before using them with the map builder?cv2.solvePnP()
calls i could just add them, for this function as you wrote it yourself its more complicated. Could it be replaced with OpenCV functions likecv2.projectPoints()
so that distortion coefficients can be used?Thanks!
The text was updated successfully, but these errors were encountered: