Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

bootstrap improvement #671

Open
rlouapre opened this issue Oct 18, 2016 · 3 comments
Open

bootstrap improvement #671

rlouapre opened this issue Oct 18, 2016 · 3 comments

Comments

@rlouapre
Copy link
Contributor

setup.xqy has

  • 47 calls to admin:get-configuration()
  • 24 calls to admin:save-configuration-without-restart()

Is there any technical reason for that?
These calls are very expensive and it could take several minutes for bootstrapping an application with replica forest, indexes...
I was planning to simplify the code using fn:fold-left and a single call to admin:get-configuration() and admin:save-configuration-without-restart() .
But since it a major refactoring I would like to know if there are good reason to keep multiple calls to admin:get-configuration(), admin:save-configuration-without-restart()?

@RobertSzkutak
Copy link
Contributor

RobertSzkutak commented Oct 18, 2016

Somewhat related, see : #598

@dmcassel
Copy link
Collaborator

I'm not aware of any technical reason. If this could speed up bootstrap, that would be great. This would certainly require careful testing, and I think we should delay until after the release we're currently working on.

@dmcassel dmcassel added this to the 1.7.5 milestone Oct 21, 2016
@RobertSzkutak
Copy link
Contributor

RobertSzkutak commented Jan 30, 2017

Note that some improvements were made in PR #719

Also note that there is room for similar improvements to be made in other parts of the bootstrap process

@RobertSzkutak RobertSzkutak modified the milestones: April 2017, 1.7.5 Jan 30, 2017
@RobertSzkutak RobertSzkutak removed this from the April 2017 milestone May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants