Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

lint/test errors shouldn't always abort the build #267

Closed
joemfb opened this issue Nov 17, 2015 · 4 comments
Closed

lint/test errors shouldn't always abort the build #267

joemfb opened this issue Nov 17, 2015 · 4 comments
Milestone

Comments

@joemfb
Copy link
Contributor

joemfb commented Nov 17, 2015

At the very least, there needs to be an options to continue anyway. Run into this doing deployments an deadline; always fun to be forced to fix unit tests at the last minute ...

@grtjn
Copy link
Contributor

grtjn commented Dec 18, 2015

I vote for a --novet, that effectively skips the jshint and jscs validation in the vet task, or make it continue without abort.

You can also disable things manually, but then it is permanent. The minimum to get past js syntax issues without aborting is commenting out the last two lines of the vet task:

gulp.task('vet', function() {
  log('Analyzing source with JSHint and JSCS');

  return gulp
    .src(config.alljs)
    .pipe($.if(args.verbose, $.print()))
    .pipe($.jshint())
    .pipe($.jshint.reporter('jshint-stylish', {verbose: true}))
//    .pipe($.jshint.reporter('fail'))
//    .pipe($.jscs())
  ;
});

@grtjn
Copy link
Contributor

grtjn commented Jan 30, 2016

Or maybe gulp build should not vet, unless --vet was provided? (any votes?)

@grtjn
Copy link
Contributor

grtjn commented Feb 18, 2016

I added an --ignoreErrors feature as part of #305..

@joemfb
Copy link
Contributor Author

joemfb commented Feb 18, 2016

Great, that works for me!

@joemfb joemfb closed this as completed Feb 18, 2016
@grtjn grtjn modified the milestone: 1.0.2 Apr 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants