Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

minified build needs sourcemaps #268

Closed
joemfb opened this issue Nov 17, 2015 · 6 comments
Closed

minified build needs sourcemaps #268

joemfb opened this issue Nov 17, 2015 · 6 comments
Assignees
Milestone

Comments

@joemfb
Copy link
Contributor

joemfb commented Nov 17, 2015

debugging the minified build (when it exhibits behavior different from dev-mode) is very difficult. We need to generate sourcemaps along with minified assets

@grtjn
Copy link
Contributor

grtjn commented Feb 18, 2016

Does #305 include the changes needed for this?

@grtjn grtjn added this to the 1.0.3 milestone Feb 18, 2016
@joemfb
Copy link
Contributor Author

joemfb commented Feb 18, 2016

Looks like it to me; have you verified that .map files are generated? Do the right src files show up in the browser when debugging a minified build?

@grtjn
Copy link
Contributor

grtjn commented Feb 18, 2016

I do get .map files, haven't tried looking with browser. What would be an easy way to do that?

@joemfb
Copy link
Contributor Author

joemfb commented Feb 18, 2016

While running a dist/ build, check to see if console logs, errors, or breakpoints link/show the individual JS files, as opposed to the concatenated bundle (sourcemaps are enabled by default in Chrome, not sure about other browsers).

@grtjn
Copy link
Contributor

grtjn commented Feb 19, 2016

I think I got it working, to some extent at least. I see the minified js/css with a comment of which map file is associated with each, and then an extra source/ folder with the non-minified files. It doesn't show the individual files, but the concatenated version, but at least it is not minified/uglyfied..

@grtjn grtjn self-assigned this Feb 19, 2016
@grtjn
Copy link
Contributor

grtjn commented Mar 8, 2016

Fixed as described in #305, closing for now..

@grtjn grtjn closed this as completed Mar 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants