Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

Avoid /v1 in proxy.js #332

Closed
grtjn opened this issue Apr 22, 2016 · 1 comment
Closed

Avoid /v1 in proxy.js #332

grtjn opened this issue Apr 22, 2016 · 1 comment
Assignees
@grtjn
Labels
enhancement
Milestone
1.1.0

Comments

@grtjn
Copy link
Contributor

grtjn commented Apr 22, 2016

The proxy function has a hard-coded '/v1', but it is better to use req.baseUrl instead. That also makes it easier to reuse the same proxy lib to proxy '/vlatest' for instance, or add-hoc proxies like '/reports'(/my/report.xqy)..
@grtjn grtjn added this to the 1.2.0 milestone Apr 22, 2016
@grtjn grtjn modified the milestones: 1.2.0, 1.3.0 Oct 6, 2016
@grtjn grtjn mentioned this issue Nov 23, 2016
Merged
@grtjn grtjn modified the milestones: 1.1.0, 1.4.0 Nov 23, 2016
@grtjn grtjn self-assigned this Nov 23, 2016
@grtjn
Copy link
Contributor Author

grtjn commented Nov 23, 2016

A fix for this was included in 1.1.0 already..

@grtjn grtjn closed this as completed Nov 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grtjn grtjn

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@grtjn