This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

restart command not working when variable are provide from command line #317

Closed

rlouapre opened this issue Dec 9, 2014 · 4 comments

Contributor

rlouapre commented Dec 9, 2014

For example:
ml local restart --ml.password=XXXXXX

The text was updated successfully, but these errors were encountered:

Collaborator

dmcassel commented Dec 10, 2014

Just tried this and didn't see any error.

Collaborator

dmcassel commented Dec 10, 2014

Ah, I see the problem. Finish coffee, then review.

dmcassel closed this as completed in

4a276a2

dmcassel added a commit that referenced this issue


          Merge pull request #318 from rlouapre/issue-317

040991f

Fix #317

dmcassel added a commit to dmcassel/roxy that referenced this issue


          marklogic-community#317 reversing PR marklogic-community#318, as it i…

abd0a9d

…ncorrectly went to the master branch

dmcassel added a commit to dmcassel/roxy that referenced this issue


          marklogic-community#317 applying rlouapre's change to the dev branch

015b22f

dmcassel added a commit that referenced this issue


          Merge pull request #320 from dmcassel/master

8ea7dc1

#317 reversing PR #318, as it incorrectly went to the master branch

dmcassel added a commit that referenced this issue


          Merge pull request #321 from dmcassel/dev

7be7fef

#317 applying rlouapre's change to the dev branch

Contributor

grtjn commented Jan 5, 2015

It seems that above changes has a negative side-effect on restart without arguments:

$ ./ml local restart
ERROR: undefined method `index' for nil:NilClass
ERROR: ["/Users/gjosten/Projects/github-grtjn/roxy/deploy/lib/server_config.rb:404:in `restart'", "deploy/lib/ml.rb:148:in `<main>'"]

line 404 needs an extra check if group exists (if group && group.index...).

grtjn reopened this

grtjn added a commit to grtjn/roxy that referenced this issue


          Fixed marklogic-community#317: fixed regression in restart, and loggi…

c4d6478

…ng/docs for it

dmcassel added a commit that referenced this issue


          Merge pull request #345 from grtjn/317-restart-without-group

b709c9b

Fixed #317: regression in restart

Collaborator

dmcassel commented Jan 20, 2015

fixed in dev

dmcassel closed this as completed

jmeekhof pushed a commit to jmeekhof/roxy that referenced this issue


          Fix marklogic-community#317

e0b147c

jmeekhof pushed a commit to jmeekhof/roxy that referenced this issue


          Fix marklogic-community#317

a0d294c

jmeekhof pushed a commit to jmeekhof/roxy that referenced this issue


          marklogic-community#317 reversing PR marklogic-community#318, as it i…

0d82749

…ncorrectly went to the master branch

jmeekhof pushed a commit to jmeekhof/roxy that referenced this issue


          Fix marklogic-community#317

c9ce86f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.