Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

deploy_rest doesn't use REST API to deploy options #593

Closed
dmcassel opened this issue Apr 4, 2016 · 1 comment
Closed

deploy_rest doesn't use REST API to deploy options #593

dmcassel opened this issue Apr 4, 2016 · 1 comment
Assignees
@dmcassel
Labels
bug deployer
Milestone
v1.7.4

Comments

@dmcassel
Copy link
Collaborator

dmcassel commented Apr 4, 2016

REST API options ought to be deployed by PUTting them to /v1/config/query/{name}, but instead Roxy is manually constructing the URIs and writing them to the modules database. That bypasses the validation that happens when loading the options and puts us at risk for the diverging with how the REST API works. (The divergence problem hasn't happened yet, but improperly bypassing validation has.)
@dmcassel dmcassel added this to the 1.7.4 milestone Apr 5, 2016
@dmcassel dmcassel self-assigned this Apr 7, 2016
dmcassel added a commit to dmcassel/roxy that referenced this issue Apr 7, 2016
@dmcassel
marklogic-community#593 Change deployment of REST options to use REST…
7a8928b 
… API
dmcassel added a commit to dmcassel/roxy that referenced this issue Apr 14, 2016
@dmcassel
marklogic-community#593 use https with REST when needed
b42be0c
dmcassel added a commit to dmcassel/roxy that referenced this issue Apr 14, 2016
@dmcassel
marklogic-community#593 Missed one call
e3eae80
paxtonhare added a commit that referenced this issue Apr 14, 2016
@paxtonhare
Merge pull request #597 from dmcassel/issue-593
79c996a 
#593 Change deployment of REST options to use REST API
@dmcassel
Copy link
Collaborator Author

fixed in dev

@dmcassel dmcassel mentioned this issue Jul 12, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmcassel dmcassel

Labels
bug deployer
Projects
None yet
Milestone
v1.7.4
Development

No branches or pull requests
1 participant
@dmcassel