Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Template as entry point for UI components #167

Closed
patrick-steele-idem opened this issue Oct 25, 2016 · 6 comments
Closed

Proposal: Template as entry point for UI components #167

patrick-steele-idem opened this issue Oct 25, 2016 · 6 comments

Comments

@patrick-steele-idem
Copy link
Contributor

Current setup:

src/components/my-component/

index.js

module.exports = require('marko-widgets').defineComponent({
    template: require('./template.marko'),
    getTemplateData: function(state) { ... },
    ...
});

template.marko

<div w-bind>
    ...
</div>

Proposed solution

The above setup is not bad, but there is some boilerplate that we would like to remove by making the following changes:

  • Rename: index.jscomponent.js
  • Rename: template.markoindex.marko (the template becomes the entry point)
  • Remove: require('marko-widgets').defineComponent(...)
  • Remove: template: require('./template.marko')

Marko Widgets will detect that the template is the entry point and compile the template differently such that it no longer exports a Template instance, but rather it will be a module that exports two methods:

  • render(input) - Allows the UI component be rendered via a JavaScript API (e.g., require('my-component').render({ name: 'Frank' }).appendTo(document.body);)
  • renderer(input, out) - Used by the custom tag renderer

The previous setup would now be simplified as shown below:

src/components/my-component/

component.js

module.exports = {
    getTemplateData: function(state) { ... },
    ...
};

index.marko

<div w-bind>
    ...
</div>

Additional thoughts

Future improvements

By making the template the entry point, we can do a lot more things that were not previously possible. This is because we have full control over how a Marko template is compiled while we don't have control how the user writes the JavaScript code.

Single file component

We could easily support inlining the JavaScript code for the component into the template as shown below:

<div w-bind>
    ...
</div>

<script marko-component>
var Component = {
    getTemplateData: function(state) { ... },
    ...
};
</script>

No references to marko-widgets

With the new setup, there are no references to the marko-widgets module when building a UI component. This is a good thing since it makes it easier to merge Marko Widgets functionality into the core marko package (future proposal).

Backwards compatibility

We intend to maintain backwards compatibility. Developers could start to use the new, simplified setup, but old code would continue to work.

Related proposals

@yomed
Copy link
Contributor

yomed commented Oct 25, 2016

Would there be any proposed changes to defineRenderer and defineWidget in this case? Are you looking to phase those out?

@patrick-steele-idem
Copy link
Contributor Author

@yomed

Would there be any proposed changes to defineRenderer and defineWidget in this case? Are you looking to phase those out?

To keep things simple I didn't want to go into the split renderer case, but we would also like to simplify that as well by removing the calls to defineRenderer and defineWidget:

Split widget/renderer

src/components/my-component/

renderer.js

module.exports = {
    getTemplateData: function(state) { ... },
    ...
};

widget.js

module.exports = {
    handleFooClick: function() { ... },
    ...
};

index.marko

<div w-bind>
    ...
</div>

@philidem
Copy link
Contributor

I would very much look forward to this change.

@basickarl
Copy link

Ah, this looks amazing!

Also:

module.exports = {
    getTemplateData: function(state) { ... },
    ...
};

Not?:

export default {
    getTemplateData: function(state) { ... },
    ...
};

@patrick-steele-idem
Copy link
Contributor Author

@basickarl You are free to use ES6 (you'll need to use babel on both the server and the browser if you use import/export though). We plan on allowing the following as well:

export default class {
    handleFooClick() { ... }
    handleBarClick() { ... }    
    ...
};

The only good reason to use class is that you don't have to worry about comma separators, which is kind of nice.

@patrick-steele-idem
Copy link
Contributor Author

Closing this issue in favor of the issue created on the marko repo: marko-js/marko#416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants