Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, is there any way to find scaleX in metadata #131

Open
big97kai opened this issue Nov 29, 2023 · 8 comments
Open

Hi, is there any way to find scaleX in metadata #131

big97kai opened this issue Nov 29, 2023 · 8 comments

Comments

@big97kai
Copy link
Contributor

I found scaley in metadata, but i didn't find out scaleX in this. is there any way I can find scaleX?

@marksgraham
Copy link
Owner

Hi,

Unfortunately it doesn't seem to be scored directly in the .e2e (I assume you're referring to .e2e here). It looks like you might have to calculate it from other quantities ... there is some disucssion of it here.

@big97kai
Copy link
Contributor Author

big97kai commented Dec 4, 2023

@marksgraham thank you for all your disscussion, it's a gerat help. But have you encountered a situation where posx2-posx1 is 0 or a changing value? This means that the value is not a fixed 20 or 30.

@big97kai
Copy link
Contributor Author

big97kai commented Dec 4, 2023

Unfortunately, I don't think these tricks work. For example, I found that the posx1 and pos2 of the metadata of the same set of pictures changed, which was very strange. Obviously what I saw on Heidelberg was the same. The second problem is that the distance between the viewer and the probe in real space should change with the angle. , the same is 20°. After calculation, the distance changes, and there is a slight difference.

@marksgraham
Copy link
Owner

Afraid it looks like we're still missing something.. :(

@big97kai
Copy link
Contributor Author

@marksgraham I finished the time stamp, and double checking that's it's correct(at least it works for my machine), where should I put a global constant.....
And there is another question... Since Optical Coherence Tomography (OCT) comes in various types, such as some OCTs having a cross-shaped pattern with 4 or 8 cuts, and others featuring a horizontal pattern with a higher number of cuts, how should I differentiate between them?

@marksgraham
Copy link
Owner

there is a single time stamp for each .e2e file? could you store with these class attributes:

self.pixel_spacing = None

currently we don't differentiate and assume all scans are just the horizontal patterns you've described. maybe we should, as a minimum, store a 'scan type' parameter somewhere where we can try to describe this? there must be a flag in the .e2e files that encodes this but I have not looked for it, I think all the scans I have previously worked with were the more standard volume shape

@big97kai
Copy link
Contributor Author

big97kai commented Feb 1, 2024

Thank you for your instruction. I finish the timstamp PR, looking forward more testing. LOL

Besides that, I found out something interst which could be relevent to type.
I notice that theres a scanType in metadata is that relevent to scanType ...?

@marksgraham
Copy link
Owner

possibly... does it seem to change with the different types of oct scan you see (e.g. cross, horizontal)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants