Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BYSETPOS to RecurrenceRule #113

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Add BYSETPOS to RecurrenceRule #113

merged 4 commits into from
Oct 10, 2018

Conversation

theeternalsw0rd
Copy link
Contributor

Reformatted some code to match style. Hopefully travis build passes now.

@theeternalsw0rd
Add BYSETPOS to RecurrenceRule
214a1bb 
Adds BYSETPOS with proper input validation. Can accept null|int|string|array. Other methods seem to throw on valid input. For example BYMONTH is a csv string in the spec, but the set method only accepts a single integer. I figured I should save refactoring for another pull request.
@theeternalsw0rd
match changes to original formatting
cedc854
@theeternalsw0rd
More formatting matching
cb847a3
@theeternalsw0rd theeternalsw0rd changed the title Updated pull request Add BYSETPOS to RecurrenceRule Mar 30, 2018
@theeternalsw0rd
Copy link
Contributor Author

Sorry for the clutter. Should have left original pull request in place. Didn't realize github would automatically update. Here's what I put in the initial pull request description:

Adds BYSETPOS with proper input validation. Can accept null|int|string|array. Other methods seem to throw on valid input. For example BYMONTH is a csv string in the spec, but the set method only accepts a single integer. I figured I should save refactoring for another pull request.

@wendelin
Copy link

I need BYSETPOS.
Is there any chance of this getting merged anytime soon?

@theeternalsw0rd
Copy link
Contributor Author

Glad you pinged this as I noticed an error in my pull request. I'm not sure if this will get merged anytime soon though. The project has been dormant for half a year now.

@markuspoerschke markuspoerschke merged commit 4a01869 into markuspoerschke:master Oct 10, 2018
@markuspoerschke
Copy link
Owner

Looks good, thanks!

markuspoerschke added a commit that referenced this pull request Oct 10, 2018
@markuspoerschke
Update CHANGELOG
48fd014 
Add #113 BYSETPOS to RecurrenceRule
@markuspoerschke
Copy link
Owner

Thanks for your contribution! This change will be available in 0.15.0!

@theeternalsw0rd theeternalsw0rd deleted the patch-1 branch April 16, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theeternalsw0rd @wendelin @markuspoerschke