forked from scroll-tech/scroll
-
Notifications
You must be signed in to change notification settings - Fork 0
/
L1ETHGateway.t.sol
559 lines (482 loc) · 20.6 KB
/
L1ETHGateway.t.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
// SPDX-License-Identifier: MIT
pragma solidity =0.8.24;
import {ITransparentUpgradeableProxy} from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
import {L1GatewayRouter} from "../L1/gateways/L1GatewayRouter.sol";
import {IL1ETHGateway, L1ETHGateway} from "../L1/gateways/L1ETHGateway.sol";
import {IL1ScrollMessenger} from "../L1/IL1ScrollMessenger.sol";
import {IL2ETHGateway, L2ETHGateway} from "../L2/gateways/L2ETHGateway.sol";
import {AddressAliasHelper} from "../libraries/common/AddressAliasHelper.sol";
import {ScrollConstants} from "../libraries/constants/ScrollConstants.sol";
import {L1GatewayTestBase} from "./L1GatewayTestBase.t.sol";
import {MockScrollMessenger} from "./mocks/MockScrollMessenger.sol";
import {MockGatewayRecipient} from "./mocks/MockGatewayRecipient.sol";
contract L1ETHGatewayTest is L1GatewayTestBase {
// from L1ETHGateway
event DepositETH(address indexed from, address indexed to, uint256 amount, bytes data);
event FinalizeWithdrawETH(address indexed from, address indexed to, uint256 amount, bytes data);
event RefundETH(address indexed recipient, uint256 amount);
L1ETHGateway private gateway;
L1GatewayRouter private router;
L2ETHGateway private counterpartGateway;
function setUp() public {
__L1GatewayTestBase_setUp();
// Deploy L2 contracts
counterpartGateway = new L2ETHGateway(address(1), address(1), address(1));
// Deploy L1 contracts
router = L1GatewayRouter(_deployProxy(address(new L1GatewayRouter())));
gateway = _deployGateway(address(l1Messenger));
// Initialize L1 contracts
gateway.initialize(address(counterpartGateway), address(router), address(l1Messenger));
router.initialize(address(gateway), address(0));
}
function testInitialized() public {
assertEq(address(counterpartGateway), gateway.counterpart());
assertEq(address(router), gateway.router());
assertEq(address(l1Messenger), gateway.messenger());
hevm.expectRevert("Initializable: contract is already initialized");
gateway.initialize(address(counterpartGateway), address(router), address(l1Messenger));
}
function testDepositETH(
uint256 amount,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETH(false, amount, gasLimit, feePerGas);
}
function testDepositETHWithRecipient(
uint256 amount,
address recipient,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETHWithRecipient(false, amount, recipient, gasLimit, feePerGas);
}
function testDepositETHWithRecipientAndCalldata(
uint256 amount,
address recipient,
bytes memory dataToCall,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETHWithRecipientAndCalldata(false, amount, recipient, dataToCall, gasLimit, feePerGas);
}
function testRouterDepositETH(
uint256 amount,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETH(true, amount, gasLimit, feePerGas);
}
function testRouterDepositETHWithRecipient(
uint256 amount,
address recipient,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETHWithRecipient(true, amount, recipient, gasLimit, feePerGas);
}
function testRouterDepositETHWithRecipientAndCalldata(
uint256 amount,
address recipient,
bytes memory dataToCall,
uint256 gasLimit,
uint256 feePerGas
) public {
_depositETHWithRecipientAndCalldata(true, amount, recipient, dataToCall, gasLimit, feePerGas);
}
function testDropMessageMocking() public {
MockScrollMessenger mockMessenger = new MockScrollMessenger();
gateway = _deployGateway(address(mockMessenger));
gateway.initialize(address(counterpartGateway), address(router), address(mockMessenger));
// only messenger can call, revert
hevm.expectRevert(ErrorCallerIsNotMessenger.selector);
gateway.onDropMessage(new bytes(0));
// only called in drop context, revert
hevm.expectRevert(ErrorNotInDropMessageContext.selector);
mockMessenger.callTarget(
address(gateway),
abi.encodeWithSelector(gateway.onDropMessage.selector, new bytes(0))
);
mockMessenger.setXDomainMessageSender(ScrollConstants.DROP_XDOMAIN_MESSAGE_SENDER);
// invalid selector, revert
hevm.expectRevert("invalid selector");
mockMessenger.callTarget(
address(gateway),
abi.encodeWithSelector(gateway.onDropMessage.selector, new bytes(4))
);
bytes memory message = abi.encodeWithSelector(
IL2ETHGateway.finalizeDepositETH.selector,
address(this),
address(this),
100,
new bytes(0)
);
// msg.value mismatch, revert
hevm.expectRevert("msg.value mismatch");
mockMessenger.callTarget{value: 99}(
address(gateway),
abi.encodeWithSelector(gateway.onDropMessage.selector, message)
);
}
function testDropMessage(
uint256 amount,
address recipient,
bytes memory dataToCall
) public {
amount = bound(amount, 1, address(this).balance);
bytes memory message = abi.encodeWithSelector(
IL2ETHGateway.finalizeDepositETH.selector,
address(this),
recipient,
amount,
dataToCall
);
gateway.depositETHAndCall{value: amount}(recipient, amount, dataToCall, defaultGasLimit);
// skip message 0
hevm.startPrank(address(rollup));
messageQueue.popCrossDomainMessage(0, 1, 0x1);
assertEq(messageQueue.pendingQueueIndex(), 1);
hevm.stopPrank();
// ETH transfer failed, revert
revertOnReceive = true;
hevm.expectRevert("ETH transfer failed");
l1Messenger.dropMessage(address(gateway), address(counterpartGateway), amount, 0, message);
// drop message 0
hevm.expectEmit(true, true, false, true);
emit RefundETH(address(this), amount);
revertOnReceive = false;
uint256 balance = address(this).balance;
l1Messenger.dropMessage(address(gateway), address(counterpartGateway), amount, 0, message);
assertEq(balance + amount, address(this).balance);
}
function testFinalizeWithdrawETHFailedMocking(
address sender,
address recipient,
uint256 amount,
bytes memory dataToCall
) public {
amount = bound(amount, 1, address(this).balance / 2);
// revert when caller is not messenger
hevm.expectRevert(ErrorCallerIsNotMessenger.selector);
gateway.finalizeWithdrawETH(sender, recipient, amount, dataToCall);
MockScrollMessenger mockMessenger = new MockScrollMessenger();
gateway = _deployGateway(address(mockMessenger));
gateway.initialize(address(counterpartGateway), address(router), address(mockMessenger));
// only call by counterpart
hevm.expectRevert(ErrorCallerIsNotCounterpartGateway.selector);
mockMessenger.callTarget(
address(gateway),
abi.encodeWithSelector(gateway.finalizeWithdrawETH.selector, sender, recipient, amount, dataToCall)
);
mockMessenger.setXDomainMessageSender(address(counterpartGateway));
// msg.value mismatch
hevm.expectRevert("msg.value mismatch");
mockMessenger.callTarget(
address(gateway),
abi.encodeWithSelector(gateway.finalizeWithdrawETH.selector, sender, recipient, amount, dataToCall)
);
// ETH transfer failed
revertOnReceive = true;
hevm.expectRevert("ETH transfer failed");
mockMessenger.callTarget{value: amount}(
address(gateway),
abi.encodeWithSelector(gateway.finalizeWithdrawETH.selector, sender, address(this), amount, dataToCall)
);
}
function testFinalizeWithdrawETHFailed(
address sender,
address recipient,
uint256 amount,
bytes memory dataToCall
) public {
amount = bound(amount, 1, address(this).balance / 2);
// deposit some ETH to L1ScrollMessenger
gateway.depositETH{value: amount}(amount, defaultGasLimit);
// do finalize withdraw eth
bytes memory message = abi.encodeWithSelector(
IL1ETHGateway.finalizeWithdrawETH.selector,
sender,
recipient,
amount,
dataToCall
);
bytes memory xDomainCalldata = abi.encodeWithSignature(
"relayMessage(address,address,uint256,uint256,bytes)",
address(uint160(address(counterpartGateway)) + 1),
address(gateway),
amount,
0,
message
);
prepareL2MessageRoot(keccak256(xDomainCalldata));
IL1ScrollMessenger.L2MessageProof memory proof;
proof.batchIndex = rollup.lastFinalizedBatchIndex();
// counterpart is not L2ETHGateway
// emit FailedRelayedMessage from L1ScrollMessenger
hevm.expectEmit(true, false, false, true);
emit FailedRelayedMessage(keccak256(xDomainCalldata));
uint256 messengerBalance = address(l1Messenger).balance;
uint256 recipientBalance = recipient.balance;
assertBoolEq(false, l1Messenger.isL2MessageExecuted(keccak256(xDomainCalldata)));
l1Messenger.relayMessageWithProof(
address(uint160(address(counterpartGateway)) + 1),
address(gateway),
amount,
0,
message,
proof
);
assertEq(messengerBalance, address(l1Messenger).balance);
assertEq(recipientBalance, recipient.balance);
assertBoolEq(false, l1Messenger.isL2MessageExecuted(keccak256(xDomainCalldata)));
}
function testFinalizeWithdrawETH(
address sender,
uint256 amount,
bytes memory dataToCall
) public {
MockGatewayRecipient recipient = new MockGatewayRecipient();
amount = bound(amount, 1, address(this).balance / 2);
// deposit some ETH to L1ScrollMessenger
gateway.depositETH{value: amount}(amount, defaultGasLimit);
// do finalize withdraw eth
bytes memory message = abi.encodeWithSelector(
IL1ETHGateway.finalizeWithdrawETH.selector,
sender,
address(recipient),
amount,
dataToCall
);
bytes memory xDomainCalldata = abi.encodeWithSignature(
"relayMessage(address,address,uint256,uint256,bytes)",
address(counterpartGateway),
address(gateway),
amount,
0,
message
);
prepareL2MessageRoot(keccak256(xDomainCalldata));
IL1ScrollMessenger.L2MessageProof memory proof;
proof.batchIndex = rollup.lastFinalizedBatchIndex();
// emit FinalizeWithdrawETH from L1ETHGateway
{
hevm.expectEmit(true, true, false, true);
emit FinalizeWithdrawETH(sender, address(recipient), amount, dataToCall);
}
// emit RelayedMessage from L1ScrollMessenger
{
hevm.expectEmit(true, false, false, true);
emit RelayedMessage(keccak256(xDomainCalldata));
}
uint256 messengerBalance = address(l1Messenger).balance;
uint256 recipientBalance = address(recipient).balance;
assertBoolEq(false, l1Messenger.isL2MessageExecuted(keccak256(xDomainCalldata)));
l1Messenger.relayMessageWithProof(address(counterpartGateway), address(gateway), amount, 0, message, proof);
assertEq(messengerBalance - amount, address(l1Messenger).balance);
assertEq(recipientBalance + amount, address(recipient).balance);
assertBoolEq(true, l1Messenger.isL2MessageExecuted(keccak256(xDomainCalldata)));
}
function _depositETH(
bool useRouter,
uint256 amount,
uint256 gasLimit,
uint256 feePerGas
) private {
amount = bound(amount, 0, address(this).balance / 2);
gasLimit = bound(gasLimit, defaultGasLimit / 2, defaultGasLimit);
feePerGas = bound(feePerGas, 0, 1000);
messageQueue.setL2BaseFee(feePerGas);
uint256 feeToPay = feePerGas * gasLimit;
bytes memory message = abi.encodeWithSelector(
IL2ETHGateway.finalizeDepositETH.selector,
address(this),
address(this),
amount,
new bytes(0)
);
bytes memory xDomainCalldata = abi.encodeWithSignature(
"relayMessage(address,address,uint256,uint256,bytes)",
address(gateway),
address(counterpartGateway),
amount,
0,
message
);
if (amount == 0) {
hevm.expectRevert("deposit zero eth");
if (useRouter) {
router.depositETH{value: amount}(amount, gasLimit);
} else {
gateway.depositETH{value: amount}(amount, gasLimit);
}
} else {
// emit QueueTransaction from L1MessageQueue
{
hevm.expectEmit(true, true, false, true);
address sender = AddressAliasHelper.applyL1ToL2Alias(address(l1Messenger));
emit QueueTransaction(sender, address(l2Messenger), 0, 0, gasLimit, xDomainCalldata);
}
// emit SentMessage from L1ScrollMessenger
{
hevm.expectEmit(true, true, false, true);
emit SentMessage(address(gateway), address(counterpartGateway), amount, 0, gasLimit, message);
}
// emit DepositETH from L1ETHGateway
hevm.expectEmit(true, true, false, true);
emit DepositETH(address(this), address(this), amount, new bytes(0));
uint256 messengerBalance = address(l1Messenger).balance;
uint256 feeVaultBalance = address(feeVault).balance;
assertEq(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
if (useRouter) {
router.depositETH{value: amount + feeToPay + extraValue}(amount, gasLimit);
} else {
gateway.depositETH{value: amount + feeToPay + extraValue}(amount, gasLimit);
}
assertEq(amount + messengerBalance, address(l1Messenger).balance);
assertEq(feeToPay + feeVaultBalance, address(feeVault).balance);
assertGt(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
}
}
function _depositETHWithRecipient(
bool useRouter,
uint256 amount,
address recipient,
uint256 gasLimit,
uint256 feePerGas
) private {
amount = bound(amount, 0, address(this).balance / 2);
gasLimit = bound(gasLimit, defaultGasLimit / 2, defaultGasLimit);
feePerGas = bound(feePerGas, 0, 1000);
messageQueue.setL2BaseFee(feePerGas);
uint256 feeToPay = feePerGas * gasLimit;
bytes memory message = abi.encodeWithSelector(
IL2ETHGateway.finalizeDepositETH.selector,
address(this),
recipient,
amount,
new bytes(0)
);
bytes memory xDomainCalldata = abi.encodeWithSignature(
"relayMessage(address,address,uint256,uint256,bytes)",
address(gateway),
address(counterpartGateway),
amount,
0,
message
);
if (amount == 0) {
hevm.expectRevert("deposit zero eth");
if (useRouter) {
router.depositETH{value: amount}(recipient, amount, gasLimit);
} else {
gateway.depositETH{value: amount}(recipient, amount, gasLimit);
}
} else {
// emit QueueTransaction from L1MessageQueue
{
hevm.expectEmit(true, true, false, true);
address sender = AddressAliasHelper.applyL1ToL2Alias(address(l1Messenger));
emit QueueTransaction(sender, address(l2Messenger), 0, 0, gasLimit, xDomainCalldata);
}
// emit SentMessage from L1ScrollMessenger
{
hevm.expectEmit(true, true, false, true);
emit SentMessage(address(gateway), address(counterpartGateway), amount, 0, gasLimit, message);
}
// emit DepositETH from L1ETHGateway
hevm.expectEmit(true, true, false, true);
emit DepositETH(address(this), recipient, amount, new bytes(0));
uint256 messengerBalance = address(l1Messenger).balance;
uint256 feeVaultBalance = address(feeVault).balance;
assertEq(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
if (useRouter) {
router.depositETH{value: amount + feeToPay + extraValue}(recipient, amount, gasLimit);
} else {
gateway.depositETH{value: amount + feeToPay + extraValue}(recipient, amount, gasLimit);
}
assertEq(amount + messengerBalance, address(l1Messenger).balance);
assertEq(feeToPay + feeVaultBalance, address(feeVault).balance);
assertGt(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
}
}
function _depositETHWithRecipientAndCalldata(
bool useRouter,
uint256 amount,
address recipient,
bytes memory dataToCall,
uint256 gasLimit,
uint256 feePerGas
) private {
amount = bound(amount, 0, address(this).balance / 2);
gasLimit = bound(gasLimit, defaultGasLimit / 2, defaultGasLimit);
feePerGas = bound(feePerGas, 0, 1000);
messageQueue.setL2BaseFee(feePerGas);
uint256 feeToPay = feePerGas * gasLimit;
bytes memory message = abi.encodeWithSelector(
IL2ETHGateway.finalizeDepositETH.selector,
address(this),
recipient,
amount,
dataToCall
);
bytes memory xDomainCalldata = abi.encodeWithSignature(
"relayMessage(address,address,uint256,uint256,bytes)",
address(gateway),
address(counterpartGateway),
amount,
0,
message
);
if (amount == 0) {
hevm.expectRevert("deposit zero eth");
if (useRouter) {
router.depositETHAndCall{value: amount}(recipient, amount, dataToCall, gasLimit);
} else {
gateway.depositETHAndCall{value: amount}(recipient, amount, dataToCall, gasLimit);
}
} else {
// emit QueueTransaction from L1MessageQueue
{
hevm.expectEmit(true, true, false, true);
address sender = AddressAliasHelper.applyL1ToL2Alias(address(l1Messenger));
emit QueueTransaction(sender, address(l2Messenger), 0, 0, gasLimit, xDomainCalldata);
}
// emit SentMessage from L1ScrollMessenger
{
hevm.expectEmit(true, true, false, true);
emit SentMessage(address(gateway), address(counterpartGateway), amount, 0, gasLimit, message);
}
// emit DepositETH from L1ETHGateway
hevm.expectEmit(true, true, false, true);
emit DepositETH(address(this), recipient, amount, dataToCall);
uint256 messengerBalance = address(l1Messenger).balance;
uint256 feeVaultBalance = address(feeVault).balance;
assertEq(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
if (useRouter) {
router.depositETHAndCall{value: amount + feeToPay + extraValue}(
recipient,
amount,
dataToCall,
gasLimit
);
} else {
gateway.depositETHAndCall{value: amount + feeToPay + extraValue}(
recipient,
amount,
dataToCall,
gasLimit
);
}
assertEq(amount + messengerBalance, address(l1Messenger).balance);
assertEq(feeToPay + feeVaultBalance, address(feeVault).balance);
assertGt(l1Messenger.messageSendTimestamp(keccak256(xDomainCalldata)), 0);
}
}
function _deployGateway(address messenger) internal returns (L1ETHGateway _gateway) {
_gateway = L1ETHGateway(_deployProxy(address(0)));
admin.upgrade(
ITransparentUpgradeableProxy(address(_gateway)),
address(new L1ETHGateway(address(counterpartGateway), address(router), address(messenger)))
);
}
}