Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick filter params are not interceptable via transformParams() #188

Closed
endel opened this issue Dec 21, 2014 · 4 comments
Closed

Quick filter params are not interceptable via transformParams() #188

endel opened this issue Dec 21, 2014 · 4 comments
Labels

Comments

@endel
Copy link
Contributor

endel commented Dec 21, 2014

When I'm using quick filters it isn't possible to intercept it on transformParams method.

Example:

listView.addQuickFilter('Published', function () {
    return {
        published: true
    };
});
app.transformParams(function(params) {
    // only 'params.page' and 'params.per_page' are available
    return params; 
})

After selecting the Published quick filter, only page and per_page are available on transformParams.

Shouldn't params.published be available too?

@endel
Copy link
Contributor Author

endel commented Dec 22, 2014

Same thing using singleApiCall method. I think that every parameter should be present on transformParams, shouldn't?

@fzaninotto
Copy link
Member

yep, I agree, this is a bug.

@fzaninotto
Copy link
Member

Fixed by #211

@endel
Copy link
Contributor Author

endel commented Jan 8, 2015

Awesome @fzaninotto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants