Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-editable fields are missing padding #721

Closed
jamespsterling opened this issue Oct 7, 2015 · 3 comments
Closed

Non-editable fields are missing padding #721

jamespsterling opened this issue Oct 7, 2015 · 3 comments

Comments

@jamespsterling
Copy link

image

Seems they are missing one of the bootstrap classes, ex: 'col-sm-10'

@fzaninotto
Copy link
Member

Can't reproduce the issue. Here is a screenshot from the demo:

image

What is your browser?

@jamespsterling
Copy link
Author

Code example:

    submissions.editionView().fields(
        nga.field('submittedById', 'reference')
            .label('Submitted By')
            .targetEntity(user)
            .targetField(nga.field('name'))
            .editable(false),

html generated by ng-admin: (whole row)

<div class="has-feedback" id="row-dateSubmitted">
    <label class="col-sm-2 control-label" for="dateSubmitted">Date Submitted
    <!-- ngIf: field.validation().required -->&nbsp;</label>
    <!-- ngIf: field.editable() --><!-- ngIf: !field.editable() -->

    <div class="date-time">
        <p class="form-control-static"><span>Oct 6, 2015 7:32:14 AM</span></p>
    </div><!-- end ngIf: !field.editable() -->
</div>

seems the non-editable fields are missing a class that add padding to the left,

.col-lg-1, .col-lg-10, .col-lg-11, .col-lg-12, .col-lg-2, .col-lg-3, .col-lg-4, .col-lg-5, .col-lg-6, .col-lg-7, .col-lg-8, .col-lg-9, .col-md-1, .col-md-10, .col-md-11, .col-md-12, .col-md-2, .col-md-3, .col-md-4, .col-md-5, .col-md-6, .col-md-7, .col-md-8, .col-md-9, .col-sm-1, .col-sm-10, .col-sm-11, .col-sm-12, .col-sm-2, .col-sm-3, .col-sm-4, .col-sm-5, .col-sm-6, .col-sm-7, .col-sm-8, .col-sm-9, .col-xs-1, .col-xs-10, .col-xs-11, .col-xs-12, .col-xs-2, .col-xs-3, .col-xs-4, .col-xs-5, .col-xs-6, .col-xs-7, .col-xs-8, .col-xs-9 {
    position: relative;
    min-height: 1px;
    padding-left: 15px;
    padding-right: 15px;
}

@jamespsterling
Copy link
Author

I found the problem, I'm adding .cssClasses('date-time') to a handful of the fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants